[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/71] vhost-user-test: support VHOST_USER_PROTO
|
From: |
Thomas Huth |
|
Subject: |
Re: [Qemu-devel] [PATCH 09/71] vhost-user-test: support VHOST_USER_PROTOCOL_F_CROSS_ENDIAN |
|
Date: |
Fri, 7 Dec 2018 06:50:43 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 |
On 2018-12-06 21:06, Paolo Bonzini wrote:
> On 06/12/18 17:15, Thomas Huth wrote:
>>>
>>> - for (j = 0; j < 256; j++) {
>>> - uint32_t a = readl(s->memory.regions[i].guest_phys_addr + j*4);
>>> + for (j = 0; j < 1024; j++) {
>>> + uint32_t a = readb(s->memory.regions[i].guest_phys_addr + j);
>> Can't you simply use memread() intead?
>
> Yes, I guess I could do memread + memcmp, but I wanted to change the
> code as little as possible here.
OK, fair.
Reviewed-by: Thomas Huth <address@hidden>
- Re: [Qemu-devel] [PATCH 03/71] vhost: restrict Linux dependency to kernel vhost, (continued)
- [Qemu-devel] [PATCH 04/71] vhost-net: compile it on all targets that have virtio-net., Paolo Bonzini, 2018/12/03
- [Qemu-devel] [PATCH 05/71] vhost-net: revamp configure logic, Paolo Bonzini, 2018/12/03
- [Qemu-devel] [PATCH 07/71] vhost-user-test: signal data_cond when s->rings changes, Paolo Bonzini, 2018/12/03
- [Qemu-devel] [PATCH 08/71] vhost-user: support cross-endian vnet headers, Paolo Bonzini, 2018/12/03
- [Qemu-devel] [PATCH 09/71] vhost-user-test: support VHOST_USER_PROTOCOL_F_CROSS_ENDIAN, Paolo Bonzini, 2018/12/03
- [Qemu-devel] [PATCH 06/71] vhost-user-test: use g_cond_broadcast, Paolo Bonzini, 2018/12/03
- [Qemu-devel] [PATCH 10/71] vhost-user-test: skip if there is no memory at address 0, Paolo Bonzini, 2018/12/03
- [Qemu-devel] [PATCH 11/71] vhost-user-test: reduce usage of global_qtest, Paolo Bonzini, 2018/12/03
- [Qemu-devel] [PATCH 12/71] vhost-user-test: create a main loop per TestServer, Paolo Bonzini, 2018/12/03
- [Qemu-devel] [PATCH 14/71] vhost-user-test: create a temporary directory per TestServer, Paolo Bonzini, 2018/12/03
- [Qemu-devel] [PATCH 17/71] tests: remove rule for nonexisting qdev-monitor-test, Paolo Bonzini, 2018/12/03