qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-4.0 5/5] tests/pxe: Make test independent fr


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH for-4.0 5/5] tests/pxe: Make test independent from global_qtest
Date: Thu, 6 Dec 2018 12:50:19 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1

On 12/6/18 10:49 AM, Thomas Huth wrote:
global_qtest is not really required here, since boot_sector_test()
is already independent from that global variable.

Inconsistency in the use of 'independent of' and 'independent from' across the series. I think both work grammatically (English is screwy that way), but I prefer 'independent of'; it also matches your existing commits such as 7cbe423c.


Signed-off-by: Thomas Huth <address@hidden>
---
  tests/pxe-test.c | 7 ++++---
  1 file changed, 4 insertions(+), 3 deletions(-)


Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]