[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-4.0 2/5] spapr: Use default_machine_opts to
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH for-4.0 2/5] spapr: Use default_machine_opts to set use_hotplug_event_source |
Date: |
Thu, 6 Dec 2018 09:29:25 +1100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Wed, Dec 05, 2018 at 06:58:24PM -0200, Eduardo Habkost wrote:
> Instead of setting use_hotplug_event_source at instance_init
> time, set default_machine_opts on spapr_machine_2_7_class_options()
> to implement equivalent behavior.
>
> This will let us eliminate the need for separate instance_init
> functions for each spapr machine-type.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
Acked-by: David Gibson <address@hidden>
> ---
> hw/ppc/spapr.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index 80d8498867..f6b60e6fbd 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -4240,10 +4240,7 @@ static void phb_placement_2_7(sPAPRMachineState
> *spapr, uint32_t index,
>
> static void spapr_machine_2_7_instance_options(MachineState *machine)
> {
> - sPAPRMachineState *spapr = SPAPR_MACHINE(machine);
> -
> spapr_machine_2_8_instance_options(machine);
> - spapr->use_hotplug_event_source = false;
> }
>
> static void spapr_machine_2_7_class_options(MachineClass *mc)
> @@ -4252,6 +4249,7 @@ static void
> spapr_machine_2_7_class_options(MachineClass *mc)
>
> spapr_machine_2_8_class_options(mc);
> mc->default_cpu_type = POWERPC_CPU_TYPE_NAME("power7_v2.3");
> + mc->default_machine_opts = "modern-hotplug-events=off";
> SET_MACHINE_COMPAT(mc, SPAPR_COMPAT_2_7);
> smc->phb_placement = phb_placement_2_7;
> }
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH for-4.0 0/5] spapr/virt/pc: Eliminate custom instance_init functions, Eduardo Habkost, 2018/12/05
- [Qemu-devel] [PATCH for-4.0 1/5] virt: Eliminate separate instance_init functions, Eduardo Habkost, 2018/12/05
- [Qemu-devel] [PATCH for-4.0 2/5] spapr: Use default_machine_opts to set use_hotplug_event_source, Eduardo Habkost, 2018/12/05
- Re: [Qemu-devel] [PATCH for-4.0 2/5] spapr: Use default_machine_opts to set use_hotplug_event_source,
David Gibson <=
- [Qemu-devel] [PATCH for-4.0 3/5] spapr: Use default_machine_opts to set suppress_vmdesc, Eduardo Habkost, 2018/12/05
- [Qemu-devel] [PATCH for-4.0 5/5] pc: Use default_machine_opts to set suppress_vmdesc, Eduardo Habkost, 2018/12/05
- [Qemu-devel] [PATCH for-4.0 4/5] spapr: Delete instance_options functions, Eduardo Habkost, 2018/12/05