Re: [Qemu-devel] [PATCH for-3.1? 1/5] crypto/block-luks: fix memory leak in qcrypto_block_luks_create

[Peter Maydell]

On Tue, 4 Dec 2018 at 18:50, Vladimir Sementsov-Ogievskiy
<address@hidden> wrote:
>
> Free block->cipher and block->ivgen on error path.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <address@hidden>
> ---
>  crypto/block-luks.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/crypto/block-luks.c b/crypto/block-luks.c
> index 5738124773..51e24d23ca 100644
> --- a/crypto/block-luks.c
> +++ b/crypto/block-luks.c
> @@ -1341,6 +1341,9 @@ qcrypto_block_luks_create(QCryptoBlock *block,
>      qcrypto_ivgen_free(ivgen);
>      qcrypto_cipher_free(cipher);
>
> +    qcrypto_cipher_free(block->cipher);
> +    qcrypto_ivgen_free(block->ivgen);
> +
>      g_free(luks);
>      return -1;
>  }
> --

Too late for 3.1, I'm afraid. You should probably add the
cc tag for stable.

thanks
-- PMM