Re: [Qemu-devel] [PATCH v2 1/3] qapi: Turn ShutdownCause into QAPI enum

[Eric Blake]

On 12/3/18 3:26 AM, Dominik Csapak wrote:
> Needed so the patch after next can add ShutdownCause to QMP events
> SHUTDOWN and RESET.
>
> Signed-off-by: Dominik Csapak <address@hidden>
> ---
>   include/sysemu/sysemu.h | 20 --------------------
>   qapi/run-state.json     | 34 ++++++++++++++++++++++++++++++++++
>   2 files changed, 34 insertions(+), 20 deletions(-)

> +++ b/qapi/run-state.json

> +# @subsystem-reset: Partial guest reset that does not trigger QMP events and
> +#                  ignores --no-reboot. This is useful for sanitizing
> +#                  hypercalls on s390 that are used during kexec/kdump/boot

Is it ever possible for a user to see this state, or is the intent that 
it is internal-only?  But it's not the first time we've leaked internal 
states into enums (see, for example, 'null' within JobStatus in 
job.json), so it's not a showstopper.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org