Re: [Qemu-devel] [PATCH for-3.1?] pc:piix4: Update smbus I/O space after a migration

[Peter Maydell]

On Thu, 29 Nov 2018 at 16:44, Eric Blake <address@hidden> wrote:
>
> On 11/29/18 9:49 AM, Michael S. Tsirkin wrote:
> > On Thu, Nov 29, 2018 at 09:45:17AM -0600, Corey Minyard wrote:
> >> On 11/26/18 12:28 PM, address@hidden wrote:
> >>> From: Corey Minyard <address@hidden>
> >>>
> >>> Otherwise it won't be set up correctly and won't work after
> >>> miigration.
> >>
> >> Any opinions on this?  I think this would be good for 3.1. Without
> >> this when a migration occurs on piix4 the SMBus address space
> >> appears in the wrong place.  I'm not sure how bad that is, but
> >> SMBus certainly ceases to work.
> >>
> >> -corey
> >
> >
> > I have this queued. Thanks!
>
> We've missed -rc3. Is the problem this patch addresses severe enough to
> warrant -rc4? Is it a regression since 3.0?

The git history of the file suggests it's been like this for
at least five years, so I would suggest this is not worth
putting into -rc4 (we will have an rc4). Happy to hear
contrary views, but I don't want to bloat rc4 out more
than we can avoid...

thanks
-- PMM