[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v4 54/71] openrisc: convert to cpu_interrupt_reque
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [RFC v4 54/71] openrisc: convert to cpu_interrupt_request |
Date: |
Wed, 31 Oct 2018 16:43:59 +0000 |
User-agent: |
mu4e 1.1.0; emacs 26.1.50 |
Emilio G. Cota <address@hidden> writes:
> Cc: Stafford Horne <address@hidden>
> Reviewed-by: Richard Henderson <address@hidden>
> Signed-off-by: Emilio G. Cota <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> hw/openrisc/cputimer.c | 2 +-
> target/openrisc/cpu.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hw/openrisc/cputimer.c b/hw/openrisc/cputimer.c
> index 850f88761c..739404e4f5 100644
> --- a/hw/openrisc/cputimer.c
> +++ b/hw/openrisc/cputimer.c
> @@ -102,7 +102,7 @@ static void openrisc_timer_cb(void *opaque)
> CPUState *cs = CPU(cpu);
>
> cpu->env.ttmr |= TTMR_IP;
> - cs->interrupt_request |= CPU_INTERRUPT_TIMER;
> + cpu_interrupt_request_or(cs, CPU_INTERRUPT_TIMER);
> }
>
> switch (cpu->env.ttmr & TTMR_M) {
> diff --git a/target/openrisc/cpu.c b/target/openrisc/cpu.c
> index fb7cb5c507..cdbc9353b7 100644
> --- a/target/openrisc/cpu.c
> +++ b/target/openrisc/cpu.c
> @@ -32,8 +32,8 @@ static void openrisc_cpu_set_pc(CPUState *cs, vaddr value)
>
> static bool openrisc_cpu_has_work(CPUState *cs)
> {
> - return cs->interrupt_request & (CPU_INTERRUPT_HARD |
> - CPU_INTERRUPT_TIMER);
> + return cpu_interrupt_request(cs) & (CPU_INTERRUPT_HARD |
> + CPU_INTERRUPT_TIMER);
> }
>
> static void openrisc_disas_set_info(CPUState *cpu, disassemble_info *info)
--
Alex Bennée
- [Qemu-devel] [RFC v4 68/71] cpu: add async_run_on_cpu_no_bql, (continued)
- [Qemu-devel] [RFC v4 68/71] cpu: add async_run_on_cpu_no_bql, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 63/71] riscv: convert to cpu_has_work_with_iothread_lock, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 52/71] moxie: convert to cpu_interrupt_request, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 66/71] cpu: protect most CPU state with cpu->lock, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 59/71] cpu: introduce cpu_has_work_with_iothread_lock, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 54/71] openrisc: convert to cpu_interrupt_request, Emilio G. Cota, 2018/10/25
- Re: [Qemu-devel] [RFC v4 54/71] openrisc: convert to cpu_interrupt_request,
Alex Bennée <=
- [Qemu-devel] [RFC v4 49/71] nios: convert to cpu_interrupt_request, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 48/71] mips: convert to cpu_interrupt_request, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 31/71] ppc: use cpu_reset_interrupt, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 43/71] sh4: convert to cpu_interrupt_request, Emilio G. Cota, 2018/10/25
- [Qemu-devel] [RFC v4 70/71] cpus-common: move exclusive_idle higher in the file, Emilio G. Cota, 2018/10/25