Re: [Qemu-devel] [PATCH v3 09/19] hw: acpi: Export and generalize the PCI host AML API

[Samuel Ortiz]

Hi Philippe,

On Tue, Oct 30, 2018 at 07:04:15PM +0100, Philippe Mathieu-Daudé wrote:
> > > > > +void acpi_get_pci_holes(Range *hole, Range *hole64)
> > > 
> > > ... and this function neither, it should stay in hw/i386/acpi-build.c, 
> > > thus
> > > you don't need to modify the prototype and can call
> > > acpi_get_pci_host(x86_machine_paths) directly.
> > > 
> > So the idea for those routines is that they're not x86 specific. As a
> > matter of fact, they will eventually get called from architecture
> > agnostic code like e.g. hw/acpi/reduced.c. So I don't think they should
> > live under hw/i386/
> 
> But PCI_HOST_PROP_PCI_HOLE_START is only defined in "hw/i386/pc.h"... This
> file is no more arch agnostic.
> 
> I can understand/accept a acpi_get_pci_holes() function, but the ranges
> shouldn't be i386 based.
Agreed, and your reviews thankfully highlighted that part.
Neither acpi_get_pci_host nor acpi_get_pci_holes should be arch specific
and I'll fix that.

Cheers,
Samuel.