Re: [Qemu-devel] [PATCH 3/3] arm: allwinner: Enable USB EHCI

[Philippe Mathieu-Daudé]

Hi Gerd,

On 30/10/18 7:38, Gerd Hoffmann wrote:
> On Mon, Oct 29, 2018 at 11:32:07PM +0100, Philippe Mathieu-Daudé wrote:
> > From: Guenter Roeck <address@hidden>
> >
> > Signed-off-by: Guenter Roeck <address@hidden>
> > Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> > [PMD: Intented tabs -> space]
> > Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> > ---
> >   hw/arm/allwinner-a10.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/hw/arm/allwinner-a10.c b/hw/arm/allwinner-a10.c
> > index 0a8ac929f5..92ab66354a 100644
> > --- a/hw/arm/allwinner-a10.c
> > +++ b/hw/arm/allwinner-a10.c
> > @@ -116,6 +116,8 @@ static void aw_a10_realize(DeviceState *dev, Error **errp)
> >       if (machine_usb(current_machine)) {
> >           sysbus_create_simple("sysbus-ohci", 0x01c14400, s->irq[64]);
> >           sysbus_create_simple("sysbus-ohci", 0x01c1c400, s->irq[65]);
> > +        sysbus_create_simple(TYPE_AW_A10_EHCI, 0x01c14000, s->irq[39]);
> > +        sysbus_create_simple(TYPE_AW_A10_EHCI, 0x01c1c000, s->irq[40]);
>
> Hmm, is this a companion controller setup?  If so, then this is a bit
> more complicated  (see ehci_create_ich9_with_companions()).

I don't have enough USB knowledge. Can we have companion setup without PCI?

Per the datashit [1] p. 215 "21. USB Host Controller", each controller 
share the same PHY. There is no mention of companion setup:

  The USB host controller includes the following features:
  ..
  - Complies with EHCI Specification, Version 1.0,
  - and  the OHCI Specification, Version 1.0a.
  ..
  - Support only 1 USB Root Port shared between EHCI and OHCI.


[1] http://linux-sunxi.org/images/1/1e/Allwinner_A10_User_manual_V1.5.pdf

> cheers,
>    Gerd