[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/5] target/mips: Misc R5900-related cosmetic
From: |
Aleksandar Markovic |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/5] target/mips: Misc R5900-related cosmetic changes |
Date: |
Tue, 30 Oct 2018 15:08:36 +0000 |
>> --- a/target/mips/translate_init.inc.c
>> +++ b/target/mips/translate_init.inc.c
>> @@ -411,18 +411,6 @@ const mips_def_t mips_defs[] =
>> .mmu_type = MMU_TYPE_R4000,
>> },
>> {
>> - /*
>> - * The Toshiba TX System RISC TX79 Core Architecture manual
>> - *
>> - * https://wiki.qemu.org/File:C790.pdf
>> - *
>> - * describes the C790 processor that is a follow-up to the
>> R5900.
>> - * There are a few notable differences in that the R5900 FPU
>> - *
>> - * - is not IEEE 754-1985 compliant,
>> - * - does not implement double format, and
>> - * - its machine code is nonstandard.
>> - */
>
> Why remove this documentation? This entry is specific to the R5900.
>
The doc content is virtually duplicated in translate.c
The FPU content is virtually duplicated twenty lines below.
This file is not a place suitable for extensive commenting.
Aleksandar