[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] target/riscv/pmp.c: pmpcfg_csr_read returns bogus v
From: |
Dayeol Lee |
Subject: |
[Qemu-devel] [PATCH] target/riscv/pmp.c: pmpcfg_csr_read returns bogus value on RV64 |
Date: |
Fri, 26 Oct 2018 18:04:27 +0000 |
pmp_read_cfg() returns 8-bit value, which is combined together to form a single
pmpcfg CSR.
The default promotion rules will result in an integer here ("i*8" is integer,
which
flows through) resulting in a 32-bit signed value on most hosts.
That's bogus on RV64I, with the high bits of the CSR being wrong.
Signed-off-by: Dayeol Lee <address@hidden>
Reviewed-by: Palmer Dabbelt <address@hidden>
---
target/riscv/pmp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/riscv/pmp.c b/target/riscv/pmp.c
index c828950..3d3906a 100644
--- a/target/riscv/pmp.c
+++ b/target/riscv/pmp.c
@@ -330,7 +330,7 @@ target_ulong pmpcfg_csr_read(CPURISCVState *env, uint32_t
reg_index)
{
int i;
target_ulong cfg_val = 0;
- uint8_t val = 0;
+ target_ulong val = 0;
if(sizeof(target_ulong) == 8)
reg_index /= 2;
--
2.7.4
- [Qemu-devel] [PATCH] target/riscv/pmp.c: pmpcfg_csr_read returns bogus value on RV64,
Dayeol Lee <=