[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [libvirt] [PATCH 2/3] adlib: mark as insecure and depre
From: |
Daniel P . Berrangé |
Subject: |
Re: [Qemu-devel] [libvirt] [PATCH 2/3] adlib: mark as insecure and deprecated. |
Date: |
Thu, 25 Oct 2018 21:40:29 +0100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Thu, Oct 25, 2018 at 04:26:16PM +0530, P J P wrote:
> +-- On Thu, 25 Oct 2018, Gerd Hoffmann wrote --+
> | We have a lovely, guest-triggerable buffer overflow in opl2 emulation.
> |
> | Reproducer:
> | outw(0xff60, 0x220);
> | outw(0x1020, 0x220);
> | outw(0xffb0, 0x220);
> | Result:
> | Will overflow FM_OPL->AR_TABLE[] (see hw/audio/fmopl.[ch])
>
> + Reported-by: Wangjunqing <address@hidden>
So you have a CVE number for this ?
If so, it should be referenced in the commit message too, even if
we can't fix the problem.
> | diff --git a/hw/audio/adlib.c b/hw/audio/adlib.c
> | index 97b876c..fb4a29c 100644
> | --- a/hw/audio/adlib.c
> | +++ b/hw/audio/adlib.c
> | @@ -311,6 +311,7 @@ static void adlib_class_initfn (ObjectClass *klass,
> void *data)
> | set_bit(DEVICE_CATEGORY_SOUND, dc->categories);
> | dc->desc = ADLIB_DESC;
> | dc->props = adlib_properties;
> | + dc->deprecation_reason = "insecure, buffer overflow in opl2 emulation";
> | }
> |
> | static const TypeInfo adlib_info = {
> | diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi
> | index 11b870c..7951a4f 100644
> | --- a/qemu-deprecated.texi
> | +++ b/qemu-deprecated.texi
> | @@ -116,6 +116,10 @@ The @option{[hub_id name]} parameter tuple of the
> 'hostfwd_add' and
> | The ``ivshmem'' device type is replaced by either the ``ivshmem-plain''
> | or ``ivshmem-doorbell`` device types.
> |
> | address@hidden adlib (since 3.1)
> | +
> | +Has known buffer overflow.
It would be good to give a recommendation to a better choice to
replace its usage
> | +
> | @section System emulator machines
> |
> | @subsection pc-0.10 and pc-0.11 (since 3.0)
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [Qemu-devel] [PATCH 3/3] cirrus: mark as deprecated, (continued)
- Re: [Qemu-devel] [PATCH 3/3] cirrus: mark as deprecated, Dr. David Alan Gilbert, 2018/10/26
- Re: [Qemu-devel] [libvirt] [PATCH 3/3] cirrus: mark as deprecated, Christian Borntraeger, 2018/10/26
- Re: [Qemu-devel] [libvirt] [PATCH 3/3] cirrus: mark as deprecated, Cole Robinson, 2018/10/26
- Re: [Qemu-devel] [libvirt] [PATCH 3/3] cirrus: mark as deprecated, Daniel P . Berrangé, 2018/10/26
- Re: [Qemu-devel] [PATCH 3/3] cirrus: mark as deprecated, Gerd Hoffmann, 2018/10/29
[Qemu-devel] [PATCH 2/3] adlib: mark as insecure and deprecated., Gerd Hoffmann, 2018/10/25
Re: [Qemu-devel] [PATCH 2/3] adlib: mark as insecure and deprecated., Philippe Mathieu-Daudé, 2018/10/25
Re: [Qemu-devel] [PATCH 2/3] adlib: mark as insecure and deprecated., Thomas Huth, 2018/10/25
Re: [Qemu-devel] [PATCH 2/3] adlib: mark as insecure and deprecated., Paolo Bonzini, 2018/10/26