[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 4/6] debian-bootstrap.pre: Modern shell scripting (us
From: |
Thomas Huth |
Subject: |
[Qemu-devel] [PULL 4/6] debian-bootstrap.pre: Modern shell scripting (use $() instead of ``) |
Date: |
Wed, 24 Oct 2018 10:52:06 +0100 |
From: Mao Zhongyi <address@hidden>
Various shell files contain a mix between obsolete ``
and modern $(); It would be nice to convert to using $()
everywhere.
Signed-off-by: Mao Zhongyi <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Tested-by: Alex Bennée <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>
---
tests/docker/dockerfiles/debian-bootstrap.pre | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/docker/dockerfiles/debian-bootstrap.pre
b/tests/docker/dockerfiles/debian-bootstrap.pre
index 3b0ef95..c164778 100755
--- a/tests/docker/dockerfiles/debian-bootstrap.pre
+++ b/tests/docker/dockerfiles/debian-bootstrap.pre
@@ -2,7 +2,7 @@
#
# Simple wrapper for debootstrap, run in the docker build context
#
-FAKEROOT=`which fakeroot 2> /dev/null`
+FAKEROOT=$(which fakeroot 2> /dev/null)
# debootstrap < 1.0.67 generates empty sources.list, see Debian#732255
MIN_DEBOOTSTRAP_VERSION=1.0.67
@@ -52,7 +52,7 @@ fi
if [ -z $DEBOOTSTRAP_DIR ]; then
NEED_DEBOOTSTRAP=false
- DEBOOTSTRAP=`which debootstrap 2> /dev/null`
+ DEBOOTSTRAP=$(which debootstrap 2> /dev/null)
if [ -z $DEBOOTSTRAP ]; then
echo "No debootstrap installed, attempting to install from SCM"
NEED_DEBOOTSTRAP=true
--
1.8.3.1
- [Qemu-devel] [PULL 0/6] qtest, Makefiles and shell script improvements, Thomas Huth, 2018/10/24
- [Qemu-devel] [PULL 1/6] tests/migration-test: Disable s390x test when running with TCG, Thomas Huth, 2018/10/24
- [Qemu-devel] [PULL 2/6] hw/core: Move null-machine into the common-obj list, Thomas Huth, 2018/10/24
- [Qemu-devel] [PULL 3/6] configs: Add a CONFIG_SMC37C669 switch for the "smc37c669-superio" device, Thomas Huth, 2018/10/24
- [Qemu-devel] [PULL 4/6] debian-bootstrap.pre: Modern shell scripting (use $() instead of ``),
Thomas Huth <=
- [Qemu-devel] [PULL 5/6] po/Makefile: Modern shell scripting (use $() instead of ``), Thomas Huth, 2018/10/24
- [Qemu-devel] [PULL 6/6] configure: Provide option to explicitly disable AVX2, Thomas Huth, 2018/10/24
- Re: [Qemu-devel] [PULL 0/6] qtest, Makefiles and shell script improvements, Peter Maydell, 2018/10/24