[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v8 00/38] target/mips: Limited support for the R
From: |
Fredrik Noring |
Subject: |
Re: [Qemu-devel] [PATCH v8 00/38] target/mips: Limited support for the R5900 |
Date: |
Tue, 23 Oct 2018 21:10:23 +0200 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
Hi Maciej,
> I have no authority to approve such a change for the kernel, but it looks
> reasonable to me and I will support you with it, with one reservation
> however. As this is an ISA extension in the vendor-specific space, I
> think it belongs to a vendor-specific namespace, so as to make it clear it
> is not a generic architectural feature and also to avoid name clashes.
>
> So it has to be called Toshiba MMI or suchlike, similarly to how I
> requested that for the Longsoon MMI feature in a recent binutils review
> (cf <https://sourceware.org/ml/binutils/2018-07/msg00201.html> and
> binutils commit 8095d2f70e1a ("MIPS/GAS: Split Loongson MMI Instructions
> from loongson2f/3a")), with all the consequences throughout.
Vendor ASE namespaces makes sense to me. I can prepare a patch for it.
> NB all but pipeline 1 instructions of these are also implemented by other
> members of the TXx9 family. They seem to be referred to as just "multiply
> and multiply-add instructions" in the TX79 manual (cf Section B.3.1).
Would
ASE_TOSHIBA_MMI -- TX79 128-bit multimedia instructions
ASE_TOSHIBA_MAC -- TXx9 multiply and multiply-add instructions (MADD etc.)
ASE_TOSHIBA_MAC1 -- TX79 pipeline 1 variant of ASE_TOSHIBA_MAC
ASE_TOSHIBA_FMA -- R5900 FPU extensions (MADD.s etc.)
be acceptable for the currently known Toshiba extensions? (Please propose
better names.) One complication is that it seems only 8 bits are available
for all vendor ASEs, and Toshiba would then scoop up half of those.
Fredrik
- [Qemu-devel] [PATCH v8 36/38] tests/tcg/mips: Test R5900 three-operand MADDU1, (continued)
- [Qemu-devel] [PATCH v8 36/38] tests/tcg/mips: Test R5900 three-operand MADDU1, Fredrik Noring, 2018/10/21
- [Qemu-devel] [PATCH v8 37/38] target/mips: Define the R5900 CPU, Fredrik Noring, 2018/10/21
- [Qemu-devel] [PATCH v8 38/38] linux-user/mips: Recognise the R5900 CPU model, Fredrik Noring, 2018/10/21
- Re: [Qemu-devel] [PATCH v8 00/38] target/mips: Limited support for the R5900, Aleksandar Markovic, 2018/10/22
- Re: [Qemu-devel] [PATCH v8 00/38] target/mips: Limited support for the R5900,
Fredrik Noring <=
- Re: [Qemu-devel] [PATCH v8 00/38] target/mips: Limited support for the R5900, Maciej W. Rozycki, 2018/10/25
- Re: [Qemu-devel] [PATCH v8 00/38] target/mips: Limited support for the R5900, Fredrik Noring, 2018/10/26
Re: [Qemu-devel] [PATCH v8 00/38] target/mips: Limited support for the R5900, Philippe Mathieu-Daudé, 2018/10/22
Re: [Qemu-devel] [PATCH v8 00/38] target/mips: Limited support for the R5900, Fredrik Noring, 2018/10/23