|
| From: | Richard Henderson |
| Subject: | Re: [Qemu-devel] [PATCH 1/7] decodetree: Add !extern flag to argument sets |
| Date: | Tue, 23 Oct 2018 14:54:35 +0100 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 |
On 10/23/18 2:27 PM, Philippe Mathieu-Daudé wrote:
>> + if re_fullmatch('!extern', t):
>> + extern = True
>
> It looks odd to match a negative form then use a positive one.
>
> Why not simply use 'extern'?
"!" is an escape character here.
Just "escape" would be a field named "escape".
It follows existing similar syntax for !function=foo
r~
| [Prev in Thread] | Current Thread | [Next in Thread] |