Re: [Qemu-devel] [PATCH v3 1/6] tests/acceptance: Rename the generic BootLinuxConsole test as test_x86_64_pc

[Cleber Rosa]

On 10/13/18 11:15 AM, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>  tests/acceptance/boot_linux_console.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/acceptance/boot_linux_console.py 
> b/tests/acceptance/boot_linux_console.py
> index ba3ac036da..3aa4dbe5f9 100644
> --- a/tests/acceptance/boot_linux_console.py
> +++ b/tests/acceptance/boot_linux_console.py
> @@ -15,7 +15,7 @@ from avocado_qemu import Test
>  
>  class BootLinuxConsole(Test):
>      """
> -    Boots a x86_64 Linux kernel and checks that the console is operational
> +    Boots a Linux kernel and checks that the console is operational
>      and the kernel command line is properly passed from QEMU to the kernel
>  
>      :avocado: enable
> @@ -23,7 +23,7 @@ class BootLinuxConsole(Test):
>  
>      timeout = 60
>  
> -    def test(self):
> +    def test_x86_64_pc(self):
>          if self.arch != 'x86_64':
>              self.cancel('Currently specific to the x86_64 target arch')
>          kernel_url = ('https://mirrors.kernel.org/fedora/releases/28/'
> 


This looks right, but given "self.arch" is still not on master, so I'm
holding on to giving the reviewed-by/tested-by.

Question: do you believe a maintainer and/or developer would want to
test specific machine types?