[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC v3 53/56] xtensa: acquire the BQL in cpu_has_work
From: |
Emilio G. Cota |
Subject: |
[Qemu-devel] [RFC v3 53/56] xtensa: acquire the BQL in cpu_has_work |
Date: |
Thu, 18 Oct 2018 21:06:22 -0400 |
Soon we will call cpu_has_work without the BQL.
Cc: Max Filippov <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
---
target/xtensa/cpu.c | 20 +++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/target/xtensa/cpu.c b/target/xtensa/cpu.c
index d4ca35e6cc..5cb881f89b 100644
--- a/target/xtensa/cpu.c
+++ b/target/xtensa/cpu.c
@@ -29,6 +29,7 @@
*/
#include "qemu/osdep.h"
+#include "qemu/main-loop.h"
#include "qapi/error.h"
#include "cpu.h"
#include "qemu-common.h"
@@ -42,17 +43,34 @@ static void xtensa_cpu_set_pc(CPUState *cs, vaddr value)
cpu->env.pc = value;
}
-static bool xtensa_cpu_has_work(CPUState *cs)
+static bool xtensa_cpu_has_work_locked(CPUState *cs)
{
#ifndef CONFIG_USER_ONLY
XtensaCPU *cpu = XTENSA_CPU(cs);
+ g_assert(qemu_mutex_iothread_locked());
+
return !cpu->env.runstall && cpu->env.pending_irq_level;
#else
return true;
#endif
}
+static bool xtensa_cpu_has_work(CPUState *cs)
+{
+ if (!qemu_mutex_iothread_locked()) {
+ bool ret;
+
+ cpu_mutex_unlock(cs);
+ qemu_mutex_lock_iothread();
+ cpu_mutex_lock(cs);
+ ret = xtensa_cpu_has_work_locked(cs);
+ qemu_mutex_unlock_iothread();
+ return ret;
+ }
+ return xtensa_cpu_has_work_locked(cs);
+}
+
/* CPUClass::reset() */
static void xtensa_cpu_reset(CPUState *s)
{
--
2.17.1
- [Qemu-devel] [RFC v3 50/56] s390: acquire the BQL in cpu_has_work, (continued)
- [Qemu-devel] [RFC v3 50/56] s390: acquire the BQL in cpu_has_work, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 39/56] s390x: convert to cpu_interrupt_request, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 27/56] s390x: use cpu_reset_interrupt, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 55/56] cpu: add async_run_on_cpu_no_bql, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 56/56] cputlb: queue async flush jobs without the BQL, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 29/56] arm: convert to cpu_interrupt_request, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 54/56] cpu: protect most CPU state with cpu->lock, Emilio G. Cota, 2018/10/18
- [Qemu-devel] [RFC v3 53/56] xtensa: acquire the BQL in cpu_has_work,
Emilio G. Cota <=
- Re: [Qemu-devel] [RFC v3 0/56] per-CPU locks, Paolo Bonzini, 2018/10/19