[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/4] Introduce attributes to qemu timer subsy
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/4] Introduce attributes to qemu timer subsystem |
Date: |
Thu, 18 Oct 2018 16:26:30 +0100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Thu, Oct 18, 2018 at 05:04:29PM +0600, Artem Pisarenko wrote:
> Attributes are simple flags, associated with individual timers for their
> whole lifetime.
> They intended to be used to mark individual timers for special handling by
> various qemu features which have integration into qemu-timer.
> New/init functions family in timer interface updated and refactored (new
> 'attribute' argument added, timer_list replaced with timer_list_group+type
> combinations, comments improved to avoid info duplication).
> Also existing aio interface extended with attribute-enabled variants of
> functions, which create/initialize timers.
>
> Signed-off-by: Artem Pisarenko <address@hidden>
> ---
>
> Notes:
> v3:
> - attributes has been properly incapsulated to qemu-timer (as suggested
> by Stefan Hajnoczi)
> - attributes definition and docs refactored to avoid extra enum and use
> simple macros with explicit bit positions (as suggested by Stefan Hajnoczi
> and Paolo Bonzini)
> - fixed old "QEMU_TIMER_ATTR(id)" notation (in comments) left from
> initial patch version
>
> v2:
> - timer creation/initialize functions reworked and and their unnecessary
> variants removed (as Paolo Bonzini suggested)
> - also their comments improved to avoid info duplication
>
> include/block/aio.h | 59 ++++++++++++++++++++++---
> include/qemu/timer.h | 110
> +++++++++++++++++++++++-----------------------
> tests/ptimer-test-stubs.c | 13 ++++--
> util/qemu-timer.c | 13 ++++--
> 4 files changed, 125 insertions(+), 70 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- [Qemu-devel] [PATCH v3 0/4] Introduce attributes for timers subsystem and remove QEMU_CLOCK_VIRTUAL_EXT clock type, Artem Pisarenko, 2018/10/18
- [Qemu-devel] [PATCH v3 4/4] Optimize record/replay checkpointing for all clocks it applies to, Artem Pisarenko, 2018/10/18
- [Qemu-devel] [PATCH v3 1/4] Revert some patches from recent [PATCH v6] "Fixing record/replay and adding reverse debugging", Artem Pisarenko, 2018/10/18
- [Qemu-devel] [PATCH v3 3/4] Restores record/replay behavior related to special virtual clock processing for timers used in external subsystems., Artem Pisarenko, 2018/10/18
- [Qemu-devel] [PATCH v3 2/4] Introduce attributes to qemu timer subsystem, Artem Pisarenko, 2018/10/18
- Re: [Qemu-devel] [PATCH v3 2/4] Introduce attributes to qemu timer subsystem,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v3] Optimize record/replay checkpointing for all clocks it applies to, Artem Pisarenko, 2018/10/18
- Re: [Qemu-devel] [PATCH v3] Optimize record/replay checkpointing for all clocks it applies to, Paolo Bonzini, 2018/10/18
- Re: [Qemu-devel] [PATCH v3] Optimize record/replay checkpointing for all clocks it applies to, Artem Pisarenko, 2018/10/18
- Re: [Qemu-devel] [PATCH v3] Optimize record/replay checkpointing for all clocks it applies to, Paolo Bonzini, 2018/10/18
- Re: [Qemu-devel] [PATCH v3] Optimize record/replay checkpointing for all clocks it applies to, Artem Pisarenko, 2018/10/18
- Re: [Qemu-devel] [PATCH v3] Optimize record/replay checkpointing for all clocks it applies to, Paolo Bonzini, 2018/10/18
- Re: [Qemu-devel] [PATCH v3] Optimize record/replay checkpointing for all clocks it applies to, Artem Pisarenko, 2018/10/18
Re: [Qemu-devel] [PATCH v3 0/4] Introduce attributes for timers subsystem and remove QEMU_CLOCK_VIRTUAL_EXT clock type, Artem Pisarenko, 2018/10/18
[Qemu-devel] [PATCH v3 4/4] Optimize record/replay checkpointing for all clocks it applies to, Artem Pisarenko, 2018/10/18