Re: [Qemu-devel] [PATCH v6 12/14] target/arm: PMU: Set PMCR.N to 4

[Peter Maydell]

On 17 October 2018 at 22:14, Richard Henderson
<address@hidden> wrote:
> On 10/17/18 1:25 PM, Aaron Lindsay wrote:
>> I suppose pmcrn (the local variable) should've been set to 0 before this
>> patch and updated here to be 4.
>
> That's plausible.
>
>> Anyway, by splitting these patches apart, my intention was to separate
>> the plumbing work from turning on the water. If you believe it is better
>> to do both in the same patch, I'll make that change for v7.
>
> Fair.  I'll let Peter weigh in for final decision.

No strong opinion -- rth has reviewed this set, not me.

thanks
-- PMM