[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 38/38] vpc: Fail open on bad header checksum
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v4 38/38] vpc: Fail open on bad header checksum |
Date: |
Wed, 17 Oct 2018 19:34:44 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Kevin Wolf <address@hidden> writes:
> Am 17.10.2018 um 10:27 hat Markus Armbruster geschrieben:
>> vpc_open() merely prints a warning when it finds a bad header
>> checksum. Turn that into a hard error.
>>
>> Cc: Kevin Wolf <address@hidden>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> block/vpc.c | 8 +++++---
>> 1 file changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/block/vpc.c b/block/vpc.c
>> index bf294abfa7..1729c0cb44 100644
>> --- a/block/vpc.c
>> +++ b/block/vpc.c
>> @@ -284,9 +284,11 @@ static int vpc_open(BlockDriverState *bs, QDict
>> *options, int flags,
>>
>> checksum = be32_to_cpu(footer->checksum);
>> footer->checksum = 0;
>> - if (vpc_checksum(s->footer_buf, HEADER_SIZE) != checksum)
>> - fprintf(stderr, "block-vpc: The header checksum of '%s' is "
>> - "incorrect.\n", bs->filename);
>> + if (vpc_checksum(s->footer_buf, HEADER_SIZE) != checksum) {
>> + error_setg(errp, "incorrect header checksum");
>
> Upper case would be more consistent with most other error messages in
> the vpc driver.
Sure.
>> + ret = -EINVAL;
>> + goto fail;
>> + }
>
> With that fixed:
>
> Reviewed-by: Kevin Wolf <address@hidden>
Thanks!
- [Qemu-devel] [PATCH v4 17/38] seccomp: Clean up error reporting in parse_sandbox(), (continued)
- [Qemu-devel] [PATCH v4 17/38] seccomp: Clean up error reporting in parse_sandbox(), Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 05/38] vfio: Use warn_report() & friends to report warnings, Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 25/38] ui/keymaps: Fix handling of erroneous include files, Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 26/38] ui: Convert vnc_display_init(), init_keyboard_layout() to Error, Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 04/38] cpus hw target: Use warn_report() & friends to report warnings, Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 37/38] raw: Convert a warning to warn_report(), Markus Armbruster, 2018/10/17
- [Qemu-devel] [PATCH v4 38/38] vpc: Fail open on bad header checksum, Markus Armbruster, 2018/10/17