Re: [Qemu-devel] [PATCH V6 1/5] target/i386 : add coalesced pio support

[Vitaly Kuznetsov]

Peng Hao <address@hidden> writes:

> diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h
> index 83ba4eb..b5d4289 100644
> --- a/linux-headers/linux/kvm.h
> +++ b/linux-headers/linux/kvm.h
> @@ -420,13 +420,19 @@ struct kvm_run {
>  struct kvm_coalesced_mmio_zone {
>       __u64 addr;
>       __u32 size;
> -     __u32 pad;
> +     union {
> +             __u32 pad;
> +             __u32 pio;
> +     };
>  };

I was just passing by, but what's the point in keeping 'pad'?

>  
>  struct kvm_coalesced_mmio {
>       __u64 phys_addr;
>       __u32 len;
> +     unino {

'union' I would guess? How does it compile?

>       __u32 pad;
> +     __u32 pio;
> +     };
>       __u8  data[8];
>  };
>  
> @@ -953,6 +959,7 @@ struct kvm_ppc_resize_hpt {
>  #define KVM_CAP_NESTED_STATE 157
>  #define KVM_CAP_ARM_INJECT_SERROR_ESR 158
>  #define KVM_CAP_MSR_PLATFORM_INFO 159
> +#define KVM_CAP_COALESCED_PIO 160
>  
>  #ifdef KVM_CAP_IRQ_ROUTING

-- 
Vitaly