[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 27/35] vnc: Clean up error reporting in vnc_i
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 27/35] vnc: Clean up error reporting in vnc_init_func() |
|
Date: |
Tue, 16 Oct 2018 08:52:56 +0200 |
|
User-agent: |
NeoMutt/20180716 |
> >> + error_propagate(errp, local_err);
> > Shall we use error_propagate(errp, local_err, ("Failed to init VNC
> > server: ");
> > like vnc_display_open does?
>
> I don't know.
>
> The error reporting is somewhat poor around here. Consider:
>
> $ qemu-system-x86_64 -display vnc=:0,share=nope
> qemu-system-x86_64: -display vnc=:0,share=nope: Failed to start VNC
> server: unknown vnc share= option
>
> The "Failed to start VNC server: " prefix doesn't really add value.
Indeed.
> Gerd, what do you think?
I'd keep the messages short.
cheers,
Gerd
- Re: [Qemu-devel] [PATCH v2 33/35] blockdev: Convert drive_new() to Error, (continued)
[Qemu-devel] [PATCH v2 09/35] pc: Fix machine property nvdimm-persistence error handling, Markus Armbruster, 2018/10/15
[Qemu-devel] [PATCH v2 05/35] vfio: Use warn_report() & friends to report warnings, Markus Armbruster, 2018/10/15
[Qemu-devel] [PATCH v2 29/35] tpm: Clean up error reporting in tpm_init_tpmdev(), Markus Armbruster, 2018/10/15
[Qemu-devel] [PATCH v2 07/35] char: Use error_printf() to print help and such, Markus Armbruster, 2018/10/15
[Qemu-devel] [PATCH v2 06/35] vfio: Clean up error reporting after previous commit, Markus Armbruster, 2018/10/15
[Qemu-devel] [PATCH v2 27/35] vnc: Clean up error reporting in vnc_init_func(), Markus Armbruster, 2018/10/15
Re: [Qemu-devel] [PATCH v2 27/35] vnc: Clean up error reporting in vnc_init_func(), Philippe Mathieu-Daudé, 2018/10/15
[Qemu-devel] [PATCH v2 30/35] spice: Clean up error reporting in add_channel(), Markus Armbruster, 2018/10/15
[Qemu-devel] [PATCH v2 28/35] numa: Clean up error reporting in parse_numa(), Markus Armbruster, 2018/10/15
[Qemu-devel] [PATCH v2 23/35] vl: Clean up error reporting in parse_fw_cfg(), Markus Armbruster, 2018/10/15
[Qemu-devel] [PATCH v2 04/35] cpus hw target: Use warn_report() & friends to report warnings, Markus Armbruster, 2018/10/15
[Qemu-devel] [PATCH v2 16/35] xen/pt: Fix incomplete conversion to realize(), Markus Armbruster, 2018/10/15
[Qemu-devel] [PATCH v2 13/35] l2tpv3: Improve -netdev/netdev_add/-net/... error reporting, Markus Armbruster, 2018/10/15
[Qemu-devel] [PATCH v2 24/35] vl: Clean up error reporting in device_init_func(), Markus Armbruster, 2018/10/15
[Qemu-devel] [PATCH v2 31/35] fsdev: Clean up error reporting in qemu_fsdev_add(), Markus Armbruster, 2018/10/15