Re: [Qemu-devel] [PATCH] hw/arm/virt: add DT property /secure-chosen/sdtout-path being secure UART

[Jerome Forissier]

Hi Peter,

On 10/05/2018 11:26 AM, Jerome Forissier wrote:
> +CC: Rob Herring
> 
> On 10/05/2018 11:16 AM, Peter Maydell wrote:
>> On 5 October 2018 at 09:07, Jerome Forissier
>> <address@hidden> wrote:
>>> Bindings for /secure-chosen and /secure-chosen/stdout-path have been
>>> proposed 1.5 years ago [1] and implemented in OP-TEE at the same time [2].
>>>
>>> This patch creates the property when the machine is secure.
>>>
>>> [1] https://patchwork.kernel.org/patch/9602401/
>>> [2] https://github.com/OP-TEE/optee_os/commit/4dc31c52544a
>>>
>>> Signed-off-by: Jerome Forissier <address@hidden>
>>
>> The patch seems OK, but it looks like the DT bindings are
>> not upstream yet? [*]
> 
> No, they're not.

Update: Rob has now accepted the bindings [3] (thanks!).

[3] http://patchwork.ozlabs.org/patch/980467/#2009642

-- 
Jerome

> 
>  I wouldn't want QEMU to start creating
>> bindings until the spec is definitely final.
> 
> I understand, but I think we may have a chicken-and-egg problem, because
> Rob said he'd like to see more usage of DT in secure world before
> merging the bindings ;-)
> 
> That being said, I can certainly re-submit the binding to the LKML. Rob,
> what do you say?
> 
>>
>> [*] they're not in
>> https://www.kernel.org/doc/Documentation/devicetree/bindings/arm/secure.txt
>> anyway; is that the wrong place to look?
>>
>> thanks
>> -- PMM
>>
> 
> Thanks,
>