[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 31/31] vl: Simplify call of parse_name()
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH 31/31] vl: Simplify call of parse_name() |
Date: |
Tue, 9 Oct 2018 08:06:32 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 08/10/2018 19:31, Markus Armbruster wrote:
> main() checks for parse_name() failure even though it can't actually
> fail. That's okay. Simplify it to check by passing &error_fatal,
> like the other users of qemu_opts_foreach().
>
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> vl.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 101e0123d9..0a76c58943 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -3926,10 +3926,8 @@ int main(int argc, char **argv, char **envp)
> }
> #endif
>
> - if (qemu_opts_foreach(qemu_find_opts("name"),
> - parse_name, NULL, NULL)) {
> - exit(1);
> - }
> + qemu_opts_foreach(qemu_find_opts("name"),
> + parse_name, NULL, &error_fatal);
>
> #ifndef _WIN32
> qemu_opts_foreach(qemu_find_opts("add-fd"),
>
- [Qemu-devel] [PATCH 09/31] ioapic: Fix error handling in realize(), (continued)
- [Qemu-devel] [PATCH 09/31] ioapic: Fix error handling in realize(), Markus Armbruster, 2018/10/08
- [Qemu-devel] [PATCH 29/31] vl: Assert drive_new() does not fail in default_drive(), Markus Armbruster, 2018/10/08
- [Qemu-devel] [PATCH 03/31] cpus hw target: Use warn_report() & friends to report warnings, Markus Armbruster, 2018/10/08
- [Qemu-devel] [PATCH 31/31] vl: Simplify call of parse_name(), Markus Armbruster, 2018/10/08
- Re: [Qemu-devel] [PATCH 31/31] vl: Simplify call of parse_name(),
Philippe Mathieu-Daudé <=
- [Qemu-devel] [PATCH 14/31] numa: Fix QMP command set-numa-node error handling, Markus Armbruster, 2018/10/08
- [Qemu-devel] [PATCH 25/31] numa: Clean up error reporting in parse_numa(), Markus Armbruster, 2018/10/08
- [Qemu-devel] [PATCH 01/31] Use error_fatal to simplify obvious fatal errors (again), Markus Armbruster, 2018/10/08