Re: [Qemu-devel] [PATCH 18/31] qom: Clean up error reporting in user_creatable_add_opts_foreach()

[Eric Blake]

On 10/8/18 12:31 PM, Markus Armbruster wrote:
> Calling error_report() in a function that takes an Error ** argument
> is suspicious.  user_creatable_add_opts_foreach() does that, and then
> fails without setting an error.  Its caller main(), via
> qemu_opts_foreach(), is fine with it, but clean it up anyway.
>
> Cc: Daniel P. Berrangé <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>   qemu-io.c               |  8 +++-----
>   qemu-nbd.c              |  8 +++-----
>   qom/object_interfaces.c |  4 +---
>   vl.c                    | 16 ++++++----------
>   4 files changed, 13 insertions(+), 23 deletions(-)

While I could take this through my NBD tree, I think it makes more sense 
to go through your error tree with the rest of the series.

Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org