Re: [Qemu-devel] [PATCH 04/31] vfio: Use warn_report() & friends to report warnings

[Alex Williamson]

On Mon,  8 Oct 2018 19:30:58 +0200
Markus Armbruster <address@hidden> wrote:

> The vfio code reports warnings like
> 
>     error_report(WARN_PREFIX "Could not frobnicate", DEV-NAME);
> 
> where WARN_PREFIX is defined so the message comes out as
> 
>     vfio warning: DEV-NAME: Could not frobnicate
> 
> This usage predates the introduction of warn_report() & friends in
> commit 97f40301f1d.  It's time to convert to that interface.  Since
> these functions already prefix the message with "warning: ", replace
> WARN_PREFIX by VFIO_MSG_PREFIX, so the messages come out like
> 
>     warning: vfio DEV-NAME: Could not frobnicate
> 
> The next commit will replace ERR_PREFIX.
> 
> Cc: Alex Williamson <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  hw/vfio/pci.c                 | 14 +++++++-------
>  hw/vfio/platform.c            |  4 ++--
>  include/hw/vfio/vfio-common.h |  2 +-
>  3 files changed, 10 insertions(+), 10 deletions(-)

Acked-by: Alex Williamson <address@hidden>