qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC 3/6] cputlb: track TLB use rates


From: Richard Henderson
Subject: Re: [Qemu-devel] [RFC 3/6] cputlb: track TLB use rates
Date: Sun, 7 Oct 2018 19:54:37 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0

On 10/6/18 2:45 PM, Emilio G. Cota wrote:
> @@ -753,6 +763,7 @@ void tlb_set_page_with_attrs(CPUState *cpu, target_ulong 
> vaddr,
>      }
>  
>      copy_tlb_helper_locked(te, &tn);
> +    env->tlb_desc[mmu_idx].used++;
>      qemu_spin_unlock(&env->tlb_lock);
>  }

So.. you're computing what?  Total TLB occupancy?
Perhaps a better name than "used"?

Otherwise the patch looks plausible.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]