[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qxl: check qxl_phys2virt return value
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [Qemu-devel] [PATCH] qxl: check qxl_phys2virt return value |
Date: |
Fri, 5 Oct 2018 15:56:42 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 05/10/2018 15:46, Gerd Hoffmann wrote:
> Fixes: CID 1395986
Thomas suggested yesterday [*] to use the 'Buglink:' tag, however I
can't find direct link to Coverity IDs.
[*]
https://wiki.qemu.org/Contribute/SubmitAPatch#Write_a_meaningful_commit_message
If your patch fixes a commit that is already in the repository, please
add a line with "Fixes: <full-SHA-commit-id>" below the patch
description / before your "Signed-off-by:" line in the commit message.
If your patch addresses a bug in a public bug tracker, please add a line
with "Buglink: <URL-of-the-bug>" there, too.
> Fixes: 979f7ef8966bc4495a710ed9e4af42098f92ee79> Signed-off-by: Gerd Hoffmann
> <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/display/qxl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/display/qxl.c b/hw/display/qxl.c
> index 747986478f..bbf14fb42f 100644
> --- a/hw/display/qxl.c
> +++ b/hw/display/qxl.c
> @@ -290,7 +290,7 @@ static void qxl_spice_monitors_config_async(PCIQXLDevice
> *qxl, int replay)
> }
>
> cfg = qxl_phys2virt(qxl, qxl->guest_monitors_config,
> MEMSLOT_GROUP_GUEST);
> - if (cfg->count == 1) {
> + if (cfg != NULL && cfg->count == 1) {
> qxl->guest_primary.resized = 1;
> qxl->guest_head0_width = cfg->heads[0].width;
> qxl->guest_head0_height = cfg->heads[0].height;
>