[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] tests: Add migration test for aarch64
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/1] tests: Add migration test for aarch64 |
|
Date: |
Thu, 4 Oct 2018 17:07:51 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 28/09/2018 21:47, Wei Huang wrote:
[...]> +++ b/tests/migration/aarch64/Makefile
> @@ -0,0 +1,20 @@
> +# To specify cross compiler prefix, use CROSS_PREFIX=
> +# $ make CROSS_PREFIX=aarch64-linux-gnu-
> +
> +.PHONY: all clean
> +all: a-b-kernel.h
> +
> +a-b-kernel.h: aarch64.kernel
> + echo "$$__note" > header.tmp
This won't work on a read-only fs.
Why don't you use $@ directly?
> + xxd -i $< | sed -e 's/.*int.*//' >> header.tmp
Please use:
xxd -g4 ...
xxd might not be installed on the host.
That said we should however install it on the docker cross images.
> + mv header.tmp $@
> +
> +aarch64.kernel: aarch64.elf
> + $(CROSS_PREFIX)objcopy -O binary $< $@
> +
> +aarch64.elf: a-b-kernel.S
> + $(CROSS_PREFIX)gcc -o $@ -nostdlib -Wl,--build-id=none $<
> +
> +clean:
> + @rm -rf *.kernel *.elf