Re: [Qemu-devel] [PATCH v2] MAINTAINERS: Add an entry for qemu-options* files in main directory

[Paolo Bonzini]

On 04/10/2018 12:53, Thomas Huth wrote:
> The file "qemu-options.h", "qemu-options.hx" and "qemu-options-wrapper.h"
> in the main directory are currently without maintainer according to our
> get_maintainers.pl script. Considering that the command line options are
> a public interface and thus quite important, this is quite a bad state.
> Add an entry for these files which is maintained by Paolo, since the
> option handling is tightly coupled with the code in vl.c (that Paolo
> already handles via the "Main loop" entry).
> 
> And since I'm interested in the command line interface of QEMU, add
> myself (and also Markus) as reviewer here.

Sometimes, a file is really only touched as part of changes to other
files.  Command line options can be changed by block device patches,
vl.c patches, or something else.  I think changes to qemu-options* alone
are quite rare, and I'd rather not have more stuff added to my misc tree
(and my inbox)...

Paolo

> Signed-off-by: Thomas Huth <address@hidden>
> ---
>  v2: Create a separate entry
> 
>  MAINTAINERS | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3275cc6..66c13f2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1522,6 +1522,14 @@ F: tests/test-qemu-opts.c
>  F: util/keyval.c
>  F: util/qemu-option.c
>  
> +Generic command line options
> +M: Paolo Bonzini <address@hidden>
> +R: Markus Armbruster <address@hidden>
> +R: Thomas Huth <address@hidden>
> +S: Maintained
> +F: qemu-options*
> +F: vl.c
> +
>  Coverity model
>  M: Markus Armbruster <address@hidden>
>  S: Supported
>