[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/4] cputlb: fix assert_cpu_is_self macro
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/4] cputlb: fix assert_cpu_is_self macro |
Date: |
Thu, 04 Oct 2018 11:16:41 +0100 |
User-agent: |
mu4e 1.1.0; emacs 26.1.50 |
Emilio G. Cota <address@hidden> writes:
> Signed-off-by: Emilio G. Cota <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> accel/tcg/cputlb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
> index 502eea2850..f6b388c961 100644
> --- a/accel/tcg/cputlb.c
> +++ b/accel/tcg/cputlb.c
> @@ -58,9 +58,9 @@
> } \
> } while (0)
>
> -#define assert_cpu_is_self(this_cpu) do { \
> +#define assert_cpu_is_self(cpu) do { \
> if (DEBUG_TLB_GATE) { \
> - g_assert(!cpu->created || qemu_cpu_is_self(cpu)); \
> + g_assert(!(cpu)->created || qemu_cpu_is_self(cpu)); \
> } \
> } while (0)
--
Alex Bennée
- [Qemu-devel] [PATCH v2 0/4] per-TLB lock, Emilio G. Cota, 2018/10/03
- [Qemu-devel] [PATCH v2 1/4] exec: introduce tlb_init, Emilio G. Cota, 2018/10/03
- [Qemu-devel] [PATCH v2 4/4] cputlb: read CPUTLBEntry.addr_write atomically, Emilio G. Cota, 2018/10/03
- [Qemu-devel] [PATCH v2 2/4] cputlb: fix assert_cpu_is_self macro, Emilio G. Cota, 2018/10/03
- [Qemu-devel] [PATCH v2 3/4] cputlb: serialize tlb updates with env->tlb_lock, Emilio G. Cota, 2018/10/03
- Re: [Qemu-devel] [PATCH v2 0/4] per-TLB lock, Alex Bennée, 2018/10/04