[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] gtk: fix uninitialized variable
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH] gtk: fix uninitialized variable |
|
Date: |
Wed, 3 Oct 2018 15:16:32 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 03/10/2018 14:11, Paolo Bonzini wrote:
> zoom_to_fit is never initialized to false, Coverity complains
> (not sure why GCC does not).
>
> Fixes: e8b1386ea1719525a1a92df03377764703fe8c64
> Cc: address@hidden
> Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> ui/gtk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/gtk.c b/ui/gtk.c
> index 3ddb5fe162..ec935fff90 100644
> --- a/ui/gtk.c
> +++ b/ui/gtk.c
> @@ -2136,7 +2136,7 @@ static GSList *gd_vc_gfx_init(GtkDisplayState *s,
> VirtualConsole *vc,
> QemuConsole *con, int idx,
> GSList *group, GtkWidget *view_menu)
> {
> - bool zoom_to_fit;
> + bool zoom_to_fit = false;
>
> vc->label = qemu_console_get_label(con);
> vc->s = s;
>