qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v4 1/6] block/dirty-bitmaps: add user_locked sta


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v4 1/6] block/dirty-bitmaps: add user_locked status checker
Date: Wed, 3 Oct 2018 07:19:38 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0

On 10/2/18 6:02 PM, John Snow wrote:
Instead of both frozen and qmp_locked checks, wrap it into one check.
frozen implies the bitmap is split in two (for backup), and shouldn't
be modified. qmp_locked implies it's being used by another operation,
like being exported over NBD. In both cases it means we shouldn't allow
the user to modify it in any meaningful way.

Replace any usages where we check both frozen and qmp_locked with the
new check.

Signed-off-by: John Snow <address@hidden>
---
  block/dirty-bitmap.c           |  6 ++++++
  blockdev.c                     | 29 ++++++++---------------------
  include/block/dirty-bitmap.h   |  1 +
  migration/block-dirty-bitmap.c | 10 ++--------
  4 files changed, 17 insertions(+), 29 deletions(-)


Reviewed-by: Eric Blake <address@hidden>

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org



reply via email to

[Prev in Thread] Current Thread [Next in Thread]