[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 2/6] chardev: remove qemu_chr_fe_read_all() counter
From: |
Marc-André Lureau |
Subject: |
[Qemu-devel] [PULL 2/6] chardev: remove qemu_chr_fe_read_all() counter |
Date: |
Wed, 3 Oct 2018 14:57:51 +0400 |
There is no obvious reason to have a loop counter. This limits from
reading several megabytes large buffers in one go, since socket
read/write usually have a limit.
Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
---
chardev/char-fe.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/chardev/char-fe.c b/chardev/char-fe.c
index b1f228e8b5..f158f158f8 100644
--- a/chardev/char-fe.c
+++ b/chardev/char-fe.c
@@ -56,7 +56,7 @@ int qemu_chr_fe_write_all(CharBackend *be, const uint8_t
*buf, int len)
int qemu_chr_fe_read_all(CharBackend *be, uint8_t *buf, int len)
{
Chardev *s = be->chr;
- int offset = 0, counter = 10;
+ int offset = 0;
int res;
if (!s || !CHARDEV_GET_CLASS(s)->chr_sync_read) {
@@ -88,10 +88,6 @@ int qemu_chr_fe_read_all(CharBackend *be, uint8_t *buf, int
len)
}
offset += res;
-
- if (!counter--) {
- break;
- }
}
if (qemu_chr_replay(s) && replay_mode == REPLAY_MODE_RECORD) {
--
2.19.0.271.gfe8321ec05
- [Qemu-devel] [PULL 0/6] Chardev patches, Marc-André Lureau, 2018/10/03
- [Qemu-devel] [PULL 3/6] chardev: unref if underlying chardev has no parent, Marc-André Lureau, 2018/10/03
- [Qemu-devel] [PULL 4/6] char.h: fix gtk-doc comment style, Marc-André Lureau, 2018/10/03
- [Qemu-devel] [PULL 1/6] chardev: avoid crash if no associated address, Marc-André Lureau, 2018/10/03
- [Qemu-devel] [PULL 2/6] chardev: remove qemu_chr_fe_read_all() counter,
Marc-André Lureau <=
- [Qemu-devel] [PULL 5/6] chardev: mark the calls that allow an implicit mux monitor, Marc-André Lureau, 2018/10/03
- [Qemu-devel] [PULL 6/6] chardev: use a child source for qio input source, Marc-André Lureau, 2018/10/03
- Re: [Qemu-devel] [PULL 0/6] Chardev patches, Peter Maydell, 2018/10/05