[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target/arm: Don't read r4 from v8M exception st
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH] target/arm: Don't read r4 from v8M exception stackframe twice |
|
Date: |
Tue, 2 Oct 2018 17:14:21 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 02/10/2018 17:03, Peter Maydell wrote:
> A cut-and-paste error meant we were reading r4 from the v8M
> callee-saves exception stack frame twice. This is harmless
> since it just meant we did two memory accesses to the same
> location, but it's unnecessary. Delete it.
>
> Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> target/arm/helper.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/target/arm/helper.c b/target/arm/helper.c
> index 073fb3c5cb0..5e721a65272 100644
> --- a/target/arm/helper.c
> +++ b/target/arm/helper.c
> @@ -7303,7 +7303,6 @@ static void do_v7m_exception_exit(ARMCPU *cpu)
> }
>
> pop_ok = pop_ok &&
> - v7m_stack_read(cpu, &env->regs[4], frameptr + 0x8, mmu_idx)
> &&
> v7m_stack_read(cpu, &env->regs[4], frameptr + 0x8, mmu_idx)
> &&
> v7m_stack_read(cpu, &env->regs[5], frameptr + 0xc, mmu_idx)
> &&
> v7m_stack_read(cpu, &env->regs[6], frameptr + 0x10, mmu_idx)
> &&
>