[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/9] target/arm: Rely on id regs instead of f
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 0/9] target/arm: Rely on id regs instead of features |
|
Date: |
Tue, 2 Oct 2018 15:42:59 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.0 |
On 02/10/2018 14:30, Peter Maydell wrote:
> On 27 September 2018 at 22:13, Richard Henderson
> <address@hidden> wrote:
>> There are more feature bits that could be converted, but I thought
>> I should show the work to this point to get feedback.
>>
>> This is the "v2" as compared to
>> http://lists.nongnu.org/archive/html/qemu-devel/2018-09/msg01849.html
>
> So having written the code both ways round, which do you think
> works out nicer? (or at least least-worst :-))
Using the *FEATURE*() and FIELD_DP/EX() macros are a great improvement,
the code is more concise, easier to review.
I also appreciate the arm_features enum cleaned, using the previous
macros on ISAR.
I doubt this version works worst, but it definitively looks nicer, thus
less bug-prone.