qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] cd3ed7: hw/misc: mips_itu: Fix 32/64 bit issu

From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] cd3ed7: hw/misc: mips_itu: Fix 32/64 bit issue in a line i...
Date: Fri, 22 Feb 2019 05:04:01 -0800 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: cd3ed7db22bafbabcb881f51c168a7cf5aecfa51
      
https://github.com/qemu/qemu/commit/cd3ed7db22bafbabcb881f51c168a7cf5aecfa51
  Author: Aleksandar Markovic <address@hidden>
  Date:   2019-02-21 (Thu, 21 Feb 2019)

  Changed paths:
    M hw/misc/mips_itu.c

  Log Message:
  -----------
  hw/misc: mips_itu: Fix 32/64 bit issue in a line involving shift operator

Fix 32/64 bit issue in a line involving shift operator. "1 << ..."
calculation of size is done as a 32-bit signed integer which may
then be unintentionally sign-extended into the 64-bit result. The
problem was discovered by Coverity (CID 1398648). Using "1ULL"
instead of "1" on the LHS of the shift fixes this problem.

Reported-by: Peter Maydell <address@hidden>
Signed-off-by: Aleksandar Markovic <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: 1f69d17856d77f8b76e4365da77349a15b2792b2
      
https://github.com/qemu/qemu/commit/1f69d17856d77f8b76e4365da77349a15b2792b2
  Author: Aleksandar Markovic <address@hidden>
  Date:   2019-02-21 (Thu, 21 Feb 2019)

  Changed paths:
    M tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nloc_b.c
    M tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nloc_d.c
    M tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nloc_h.c
    M tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nloc_w.c
    M tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nlzc_b.c
    M tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nlzc_d.c
    M tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nlzc_h.c
    M tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nlzc_w.c
    M tests/tcg/mips/user/ase/msa/bit-counting/test_msa_pcnt_b.c
    M tests/tcg/mips/user/ase/msa/bit-counting/test_msa_pcnt_d.c
    M tests/tcg/mips/user/ase/msa/bit-counting/test_msa_pcnt_h.c
    M tests/tcg/mips/user/ase/msa/bit-counting/test_msa_pcnt_w.c

  Log Message:
  -----------
  tests/tcg: target/mips: Correct path to headers in some test source files

Correct path to headers in tests/tcg/mips/user/ase/msa/bit-counting/*
source files.

Signed-off-by: Aleksandar Markovic <address@hidden>
Reviewed-by: Aleksandar Rikalo <address@hidden>


  Commit: e7bbc9b1c2710b70f5a2ab379655bcc113cc0f21
      
https://github.com/qemu/qemu/commit/e7bbc9b1c2710b70f5a2ab379655bcc113cc0f21
  Author: Aleksandar Markovic <address@hidden>
  Date:   2019-02-21 (Thu, 21 Feb 2019)

  Changed paths:
    A tests/tcg/mips/user/ase/msa/bit-count/test_msa_nloc_b.c
    A tests/tcg/mips/user/ase/msa/bit-count/test_msa_nloc_d.c
    A tests/tcg/mips/user/ase/msa/bit-count/test_msa_nloc_h.c
    A tests/tcg/mips/user/ase/msa/bit-count/test_msa_nloc_w.c
    A tests/tcg/mips/user/ase/msa/bit-count/test_msa_nlzc_b.c
    A tests/tcg/mips/user/ase/msa/bit-count/test_msa_nlzc_d.c
    A tests/tcg/mips/user/ase/msa/bit-count/test_msa_nlzc_h.c
    A tests/tcg/mips/user/ase/msa/bit-count/test_msa_nlzc_w.c
    A tests/tcg/mips/user/ase/msa/bit-count/test_msa_pcnt_b.c
    A tests/tcg/mips/user/ase/msa/bit-count/test_msa_pcnt_d.c
    A tests/tcg/mips/user/ase/msa/bit-count/test_msa_pcnt_h.c
    A tests/tcg/mips/user/ase/msa/bit-count/test_msa_pcnt_w.c
    R tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nloc_b.c
    R tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nloc_d.c
    R tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nloc_h.c
    R tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nloc_w.c
    R tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nlzc_b.c
    R tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nlzc_d.c
    R tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nlzc_h.c
    R tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nlzc_w.c
    R tests/tcg/mips/user/ase/msa/bit-counting/test_msa_pcnt_b.c
    R tests/tcg/mips/user/ase/msa/bit-counting/test_msa_pcnt_d.c
    R tests/tcg/mips/user/ase/msa/bit-counting/test_msa_pcnt_h.c
    R tests/tcg/mips/user/ase/msa/bit-counting/test_msa_pcnt_w.c

  Log Message:
  -----------
  tests/tcg: target/mips: Change directory name 'bit-counting' to 'bit-count'

Change directory name 'bit-counting' to 'bit-count'. This is just for
cosmetic and consistency sake. This was the only subdirectory in MSA
test directory that uses ending 'ing'.

Signed-off-by: Aleksandar Markovic <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: a4719aa85eb1adee5a5acf70c76f4ab477c68de0
      
https://github.com/qemu/qemu/commit/a4719aa85eb1adee5a5acf70c76f4ab477c68de0
  Author: Aleksandar Markovic <address@hidden>
  Date:   2019-02-21 (Thu, 21 Feb 2019)

  Changed paths:
    M tests/tcg/mips/include/wrappers_msa.h

  Log Message:
  -----------
  tests/tcg: target/mips: Add wrappers for MSA integer compare instructions

Add wrappers for MSA integer compare instructions.

Signed-off-by: Aleksandar Markovic <address@hidden>
Reviewed-by: Aleksandar Rikalo <address@hidden>


  Commit: 535db74413755701d62a49466139a6ef37ad65f4
      
https://github.com/qemu/qemu/commit/535db74413755701d62a49466139a6ef37ad65f4
  Author: Pavel Dovgalyuk <address@hidden>
  Date:   2019-02-21 (Thu, 21 Feb 2019)

  Changed paths:
    M qapi/target.json
    M target/mips/helper.c

  Log Message:
  -----------
  target/mips: implement QMP query-cpu-definitions command

This patch enables QMP-based querying of the available CPU types for
MIPS and MIPS64 platforms.

Signed-off-by: Pavel Dovgalyuk <address@hidden>
Signed-off-by: Aleksandar Markovic <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>


  Commit: f7cf2219c52f3d0f173b5b03aa193ff0efd73e9c
      
https://github.com/qemu/qemu/commit/f7cf2219c52f3d0f173b5b03aa193ff0efd73e9c
  Author: BALATON Zoltan <address@hidden>
  Date:   2019-02-21 (Thu, 21 Feb 2019)

  Changed paths:
    M hw/pci-host/bonito.c

  Log Message:
  -----------
  hw/pci-host/bonito.c: Add PCI mem region mapped at the correct address

Stop using system memory as PCI memory otherwise devices such as VGA
that have regions mapped to PCI memory clash with RAM. Use a separate
memory region for PCI memory and map it to the correct address in
system memory which allows PCI mem regions to show at the correct
address where clients expect them.

Signed-off-by: BALATON Zoltan <address@hidden>
Signed-off-by: Aleksandar Markovic <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: be9f6d1140fc8d61a2bc5e54c626b01b77dd6a8e
      
https://github.com/qemu/qemu/commit/be9f6d1140fc8d61a2bc5e54c626b01b77dd6a8e
  Author: BALATON Zoltan <address@hidden>
  Date:   2019-02-21 (Thu, 21 Feb 2019)

  Changed paths:
    M hw/mips/mips_fulong2e.c

  Log Message:
  -----------
  target/mips: fulong2e: Fix bios flash size

According to both the specifications on linux-mips.org referenced in a
comment at the beginning of the file and the flash chip part number
the bios size should be 512k not 1M.

Signed-off-by: BALATON Zoltan <address@hidden>
Signed-off-by: Aleksandar Markovic <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: fb1b0fcc03b0c15bc3580309738280ad9565b6d9
      
https://github.com/qemu/qemu/commit/fb1b0fcc03b0c15bc3580309738280ad9565b6d9
  Author: BALATON Zoltan <address@hidden>
  Date:   2019-02-21 (Thu, 21 Feb 2019)

  Changed paths:
    M hw/mips/mips_fulong2e.c

  Log Message:
  -----------
  target/mips: fulong2e: Dynamically generate SPD EEPROM data

The machine comes with 256M memory module by default but it's
upgradable so it could have different memory size. There was a TODO
comment to replace static SPD EEPROM data with dynamically generated
one to support this. Now that we have a function for that, it's easy
to do. Although this would allow larger RAM sizes, the peculiar memory
map of the machine may need some special handling to map it as low and
high memory. Because I don't know what the correct place would be for
highmem, I've left memory size fixed at 256M for now and TODO is moved
there instead.

Signed-off-by: BALATON Zoltan <address@hidden>
Signed-off-by: Aleksandar Markovic <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>


  Commit: 98e139bcec7544e2ee66117bd52bbec048fa7e4e
      
https://github.com/qemu/qemu/commit/98e139bcec7544e2ee66117bd52bbec048fa7e4e
  Author: Peter Maydell <address@hidden>
  Date:   2019-02-22 (Fri, 22 Feb 2019)

  Changed paths:
    M hw/mips/mips_fulong2e.c
    M hw/misc/mips_itu.c
    M hw/pci-host/bonito.c
    M qapi/target.json
    M target/mips/helper.c
    M tests/tcg/mips/include/wrappers_msa.h
    A tests/tcg/mips/user/ase/msa/bit-count/test_msa_nloc_b.c
    A tests/tcg/mips/user/ase/msa/bit-count/test_msa_nloc_d.c
    A tests/tcg/mips/user/ase/msa/bit-count/test_msa_nloc_h.c
    A tests/tcg/mips/user/ase/msa/bit-count/test_msa_nloc_w.c
    A tests/tcg/mips/user/ase/msa/bit-count/test_msa_nlzc_b.c
    A tests/tcg/mips/user/ase/msa/bit-count/test_msa_nlzc_d.c
    A tests/tcg/mips/user/ase/msa/bit-count/test_msa_nlzc_h.c
    A tests/tcg/mips/user/ase/msa/bit-count/test_msa_nlzc_w.c
    A tests/tcg/mips/user/ase/msa/bit-count/test_msa_pcnt_b.c
    A tests/tcg/mips/user/ase/msa/bit-count/test_msa_pcnt_d.c
    A tests/tcg/mips/user/ase/msa/bit-count/test_msa_pcnt_h.c
    A tests/tcg/mips/user/ase/msa/bit-count/test_msa_pcnt_w.c
    R tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nloc_b.c
    R tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nloc_d.c
    R tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nloc_h.c
    R tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nloc_w.c
    R tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nlzc_b.c
    R tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nlzc_d.c
    R tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nlzc_h.c
    R tests/tcg/mips/user/ase/msa/bit-counting/test_msa_nlzc_w.c
    R tests/tcg/mips/user/ase/msa/bit-counting/test_msa_pcnt_b.c
    R tests/tcg/mips/user/ase/msa/bit-counting/test_msa_pcnt_d.c
    R tests/tcg/mips/user/ase/msa/bit-counting/test_msa_pcnt_h.c
    R tests/tcg/mips/user/ase/msa/bit-counting/test_msa_pcnt_w.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/amarkovic/tags/mips-queue-feb-21-2019-v2' into staging

MIPS queue for February 21st, 2019, v2

# gpg: Signature made Thu 21 Feb 2019 18:37:04 GMT
# gpg:                using RSA key D4972A8967F75A65
# gpg: Good signature from "Aleksandar Markovic <address@hidden>" [unknown]
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 8526 FBF1 5DA3 811F 4A01  DD75 D497 2A89 67F7 5A65

* remotes/amarkovic/tags/mips-queue-feb-21-2019-v2:
  target/mips: fulong2e: Dynamically generate SPD EEPROM data
  target/mips: fulong2e: Fix bios flash size
  hw/pci-host/bonito.c: Add PCI mem region mapped at the correct address
  target/mips: implement QMP query-cpu-definitions command
  tests/tcg: target/mips: Add wrappers for MSA integer compare instructions
  tests/tcg: target/mips: Change directory name 'bit-counting' to 'bit-count'
  tests/tcg: target/mips: Correct path to headers in some test source files
  hw/misc: mips_itu: Fix 32/64 bit issue in a line involving shift operator

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/faf840a359ed...98e139bcec75
reply via email to
[Prev in Thread] Current Thread [Next in Thread]