qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] bef16a: tcg: Diagnose referenced labels that


From: Peter Maydell
Subject: [Qemu-commits] [qemu/qemu] bef16a: tcg: Diagnose referenced labels that have not been...
Date: Mon, 11 Feb 2019 10:46:11 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: bef16ab4e641636b4e85c3d863b4257ce0be4e6f
      
https://github.com/qemu/qemu/commit/bef16ab4e641636b4e85c3d863b4257ce0be4e6f
  Author: Richard Henderson <address@hidden>
  Date:   2019-02-11 (Mon, 11 Feb 2019)

  Changed paths:
    M tcg/tcg-op.h
    M tcg/tcg.c
    M tcg/tcg.h

  Log Message:
  -----------
  tcg: Diagnose referenced labels that have not been emitted

Currently, a jump to a label that is not defined anywhere will
be emitted not be relocated.  This results in a jump to a random
jump target.  With tcg debugging, print a diagnostic to the -d op
file and abort.

This could help debug or detect errors like
c2d9644e6d ("target/arm: Fix crash on conditional instruction in an IT block")

Reported-by: Roman Kapl <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 3115584d39afe8cf2a84a40549029f53792abca5
      
https://github.com/qemu/qemu/commit/3115584d39afe8cf2a84a40549029f53792abca5
  Author: Mark Cave-Ayland <address@hidden>
  Date:   2019-02-11 (Mon, 11 Feb 2019)

  Changed paths:
    M tcg/i386/tcg-target.inc.c

  Log Message:
  -----------
  tcg/i386: fix unsigned vector saturating arithmetic

Due to a cut/paste error in the original implementation, the unsigned
vector saturating arithmetic was erroneously being calculated as signed
vector saturating arithmetic.

Fixes: 8ffafbcec2 ("tcg/i386: Implement vector saturating arithmetic")
Signed-off-by: Mark Cave-Ayland <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: ae56a2ff92ac73782279abf8857585c34b15f509
      
https://github.com/qemu/qemu/commit/ae56a2ff92ac73782279abf8857585c34b15f509
  Author: Emilio G. Cota <address@hidden>
  Date:   2019-02-11 (Mon, 11 Feb 2019)

  Changed paths:
    M include/exec/exec-all.h

  Log Message:
  -----------
  exec-all: document that tlb_fill can trigger a TLB resize

Signed-off-by: Emilio G. Cota <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 6d967cb86d5b4a60ba15b497126b621ce9ca6609
      
https://github.com/qemu/qemu/commit/6d967cb86d5b4a60ba15b497126b621ce9ca6609
  Author: Emilio G. Cota <address@hidden>
  Date:   2019-02-11 (Mon, 11 Feb 2019)

  Changed paths:
    M accel/tcg/cputlb.c
    M accel/tcg/softmmu_template.h

  Log Message:
  -----------
  cputlb: update TLB entry/index after tlb_fill

We are failing to take into account that tlb_fill() can cause a
TLB resize, which renders prior TLB entry pointers/indices stale.
Fix it by re-doing the TLB entry lookups immediately after tlb_fill.

Fixes: 86e1eff8bc ("tcg: introduce dynamic TLB sizing", 2019-01-28)
Reported-by: Max Filippov <address@hidden>
Tested-by: Max Filippov <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 22c5f446514a2a4bb0dbe1fea26713da92fc85fa
      
https://github.com/qemu/qemu/commit/22c5f446514a2a4bb0dbe1fea26713da92fc85fa
  Author: Peter Maydell <address@hidden>
  Date:   2019-02-11 (Mon, 11 Feb 2019)

  Changed paths:
    M accel/tcg/cputlb.c
    M accel/tcg/softmmu_template.h
    M include/exec/exec-all.h
    M tcg/i386/tcg-target.inc.c
    M tcg/tcg-op.h
    M tcg/tcg.c
    M tcg/tcg.h

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20190211' into staging

Fix dynamic tlb resize
Fix x86 host vector saturation
Diagnose missing tcg labels

# gpg: Signature made Mon 11 Feb 2019 16:57:52 GMT
# gpg:                using RSA key 64DF38E8AF7E215F
# gpg: Good signature from "Richard Henderson <address@hidden>" [full]
# Primary key fingerprint: 7A48 1E78 868B 4DB6 A85A  05C0 64DF 38E8 AF7E 215F

* remotes/rth/tags/pull-tcg-20190211:
  cputlb: update TLB entry/index after tlb_fill
  exec-all: document that tlb_fill can trigger a TLB resize
  tcg/i386: fix unsigned vector saturating arithmetic
  tcg: Diagnose referenced labels that have not been emitted

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/a044e3de2917...22c5f446514a



reply via email to

[Prev in Thread] Current Thread [Next in Thread]