[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 3ebee3: osdep: Work around MinGW assert
From: |
GitHub |
Subject: |
[Qemu-commits] [qemu/qemu] 3ebee3: osdep: Work around MinGW assert |
Date: |
Tue, 23 Oct 2018 04:18:22 -0700 |
Branch: refs/heads/master
Home: https://github.com/qemu/qemu
Commit: 3ebee3b191e755d3f7311a6a62eea5c9628b221b
https://github.com/qemu/qemu/commit/3ebee3b191e755d3f7311a6a62eea5c9628b221b
Author: Richard Henderson <address@hidden>
Date: 2018-10-23 (Tue, 23 Oct 2018)
Changed paths:
M include/qemu/osdep.h
Log Message:
-----------
osdep: Work around MinGW assert
In several places we use assert(FEATURE), and assume that if FEATURE
is disabled, all following code is removed as unreachable. Which allows
us to compile-out functions that are only present with FEATURE, and
have a link-time failure if the functions remain used.
MinGW does not mark its internal function _assert() as noreturn, so the
compiler cannot see when code is unreachable, which leads to link errors
for this host that are not present elsewhere.
The current build-time failure concerns 62823083b8a2, but I remember
having seen this same error before. Fix it once and for all for MinGW.
Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Message-id: address@hidden
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>
**NOTE:** This service has been marked for deprecation:
https://developer.github.com/changes/2018-04-25-github-services-deprecation/
Functionality will be removed from GitHub.com on January 31st, 2019.
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [qemu/qemu] 3ebee3: osdep: Work around MinGW assert,
GitHub <=