[Qemu-commits] [qemu/qemu] c953da: softfloat: remove float64_trunc_to_int

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: c953da8f0be5e026d1c9128660736d72294feb3e
      
https://github.com/qemu/qemu/commit/c953da8f0be5e026d1c9128660736d72294feb3e
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-10-05 (Fri, 05 Oct 2018)

  Changed paths:
    M fpu/softfloat.c
    M include/fpu/softfloat.h

  Log Message:
  -----------
  softfloat: remove float64_trunc_to_int

It has not had users since f83311e476 ("target-m68k: use floatx80
internally", 2017-06-21).

Note that no other bit-width has floatX_trunc_to_int.

Reviewed-by: Alex Bennée <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: b44b5abeae4a3b54ccbd7137f59c0a8923cecec9
      
https://github.com/qemu/qemu/commit/b44b5abeae4a3b54ccbd7137f59c0a8923cecec9
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-10-05 (Fri, 05 Oct 2018)

  Changed paths:
    M .gitmodules
    A tests/fp/berkeley-softfloat-3
    A tests/fp/berkeley-testfloat-3

  Log Message:
  -----------
  gitmodules: add berkeley's softfloat + testfloat version 3

These are BSD-licensed so we can add them as submodules.

Signed-off-by: Emilio G. Cota <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 3ac1f81329f4dfdc10a51e180f9cf28dbcb02a3c
      
https://github.com/qemu/qemu/commit/3ac1f81329f4dfdc10a51e180f9cf28dbcb02a3c
  Author: Emilio G. Cota <address@hidden>
  Date:   2018-10-05 (Fri, 05 Oct 2018)

  Changed paths:
    M configure
    M tests/Makefile.include
    A tests/fp/.gitignore
    A tests/fp/Makefile
    A tests/fp/fp-test.c
    A tests/fp/platform.h
    A tests/fp/wrap.inc.c

  Log Message:
  -----------
  tests/fp/fp-test: add floating point tests

By leveraging berkeley's softfloat and testfloat.

With this we get decent coverage of softfloat.c:

$ ./fp-test -r even:    67.22% coverage
$ ./fp-test -r all:     73.11% coverage

Note that we do not yet test parts of softfloat.c that aren't
in the original softfloat library, namely:

- denormal inputs
- *_to_int16/uint16 conversions
- scalbn for fixed point
- muladd variants
- min/max
- exp2
- log2
- float*_compare (except float16_compare)

Signed-off-by: Emilio G. Cota <address@hidden>
[rth: Add the new modules to git_submodules.]
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 0019d5c3a18c31604fb55f9cec3ceb13999c4866
      
https://github.com/qemu/qemu/commit/0019d5c3a18c31604fb55f9cec3ceb13999c4866
  Author: Thomas Huth <address@hidden>
  Date:   2018-10-05 (Fri, 05 Oct 2018)

  Changed paths:
    M fpu/softfloat.c
    M include/fpu/softfloat-macros.h

  Log Message:
  -----------
  softfloat: Replace countLeadingZeros32/64 with clz32/64

Our minimum required compiler for compiling QEMU is GCC 4.1 these days,
so we can drop the support for compilers which do not provide the
__builtin_clz*() functions yet. Since the countLeadingZeros32/64 are
then identical to the clz32/64 functions, and we do not have to sync
the softloat 2 codebase with upstream anymore (softloat 3 is a complete
rewrite) we can simply replace the functions with our QEMU versions.

Suggested-by: Peter Maydell <address@hidden>
Acked-by: Alex Bennée <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 5dfbc9e4903c0121140f2945f05df48cea72dd82
      
https://github.com/qemu/qemu/commit/5dfbc9e4903c0121140f2945f05df48cea72dd82
  Author: Richard Henderson <address@hidden>
  Date:   2018-10-05 (Fri, 05 Oct 2018)

  Changed paths:
    M fpu/softfloat.c
    M include/fpu/softfloat-macros.h

  Log Message:
  -----------
  softfloat: Fix division

The __udiv_qrnnd primitive that we nicked from gmp requires its
inputs to be normalized.  We were not doing that.  Because the
inputs are nearly normalized already, finishing that is trivial.

Replace div128to64 with a "proper" udiv_qrnnd, so that this
remains a reusable primitive.

Fixes: cf07323d494
Fixes: https://bugs.launchpad.net/qemu/+bug/1793119
Tested-by: Emilio G. Cota <address@hidden>
Tested-by: Alex Bennée <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: b299e88d4261b0af30190e74005ad930e04f3a11
      
https://github.com/qemu/qemu/commit/b299e88d4261b0af30190e74005ad930e04f3a11
  Author: Richard Henderson <address@hidden>
  Date:   2018-10-05 (Fri, 05 Oct 2018)

  Changed paths:
    M include/fpu/softfloat-macros.h

  Log Message:
  -----------
  softfloat: Specialize udiv_qrnnd for x86_64

The ISA has a 128/64-bit division instruction.

Tested-by: Emilio G. Cota <address@hidden>
Tested-by: Alex Bennée <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 739df333dc8853ae6578492675a26a601d6be077
      
https://github.com/qemu/qemu/commit/739df333dc8853ae6578492675a26a601d6be077
  Author: Richard Henderson <address@hidden>
  Date:   2018-10-05 (Fri, 05 Oct 2018)

  Changed paths:
    M include/fpu/softfloat-macros.h

  Log Message:
  -----------
  softfloat: Specialize udiv_qrnnd for s390x

The ISA has a 128/64-bit division instruction.

Reviewed-by: David Hildenbrand <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 27ae5109a2ba8b6b679cce3e03e16570a34390a0
      
https://github.com/qemu/qemu/commit/27ae5109a2ba8b6b679cce3e03e16570a34390a0
  Author: Richard Henderson <address@hidden>
  Date:   2018-10-05 (Fri, 05 Oct 2018)

  Changed paths:
    M include/fpu/softfloat-macros.h

  Log Message:
  -----------
  softfloat: Specialize udiv_qrnnd for ppc64

The ISA has a 128/64-bit division instruction, though it assumes the
low 64-bits of the numerator are 0, and so requires a bit more fixup
than a full 128-bit division insn.

Reviewed-by: David Gibson <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>


  Commit: 079911cb6e26898e16f5bb56ef4f9d33cf92d32d
      
https://github.com/qemu/qemu/commit/079911cb6e26898e16f5bb56ef4f9d33cf92d32d
  Author: Peter Maydell <address@hidden>
  Date:   2018-10-08 (Mon, 08 Oct 2018)

  Changed paths:
    M .gitmodules
    M configure
    M fpu/softfloat.c
    M include/fpu/softfloat-macros.h
    M include/fpu/softfloat.h
    M tests/Makefile.include
    A tests/fp/.gitignore
    A tests/fp/Makefile
    A tests/fp/berkeley-softfloat-3
    A tests/fp/berkeley-testfloat-3
    A tests/fp/fp-test.c
    A tests/fp/platform.h
    A tests/fp/wrap.inc.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/rth/tags/pull-fpu-20181005' into staging

Testing infrastructure for softfpu (not run by default).
Drop countLeadingZeros.
Fix div_floats.
Add udiv_qrnnd specializations for x86_64, s390x, ppc64 hosts.

# gpg: Signature made Fri 05 Oct 2018 19:00:09 BST
# gpg:                using RSA key 64DF38E8AF7E215F
# gpg: Good signature from "Richard Henderson <address@hidden>"
# Primary key fingerprint: 7A48 1E78 868B 4DB6 A85A  05C0 64DF 38E8 AF7E 215F

* remotes/rth/tags/pull-fpu-20181005:
  softfloat: Specialize udiv_qrnnd for ppc64
  softfloat: Specialize udiv_qrnnd for s390x
  softfloat: Specialize udiv_qrnnd for x86_64
  softfloat: Fix division
  softfloat: Replace countLeadingZeros32/64 with clz32/64
  tests/fp/fp-test: add floating point tests
  gitmodules: add berkeley's softfloat + testfloat version 3
  softfloat: remove float64_trunc_to_int

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/bb94c11985a4...079911cb6e26
      **NOTE:** This service has been marked for deprecation: 
https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.