Re: [Qemu-block] [Qemu-devel] [PATCH for-QEMU-4.1 v5 16/29] hw/arm: Express dependencies of the virt machine with Kconfig

[Peter Maydell]

On Mon, 29 Apr 2019 at 16:34, Thomas Huth <address@hidden> wrote:
>
> On 25/04/2019 17.53, Philippe Mathieu-Daudé wrote:
> > Hi Thomas,
> >
> > On 4/18/19 8:00 PM, Thomas Huth wrote:
> >> Dependencies have been determined by looking at hw/arm/virt.c
> >>
> >> Signed-off-by: Thomas Huth <address@hidden>
> >> ---
> >>  default-configs/arm-softmmu.mak | 11 +----------
> >>  hw/arm/Kconfig                  | 19 +++++++++++++++++++
> >>  hw/arm/Makefile.objs            |  3 ++-
> >>  3 files changed, 22 insertions(+), 11 deletions(-)

> > Without -nodefaults I get:
> > qemu-system-aarch64: Unsupported NIC model: virtio-net-pci
> > This is expected.
>
> Yes, it should still work with "-nic none" or "-nodefaults".

Er, if you need either -nic none or -nodefaults after this
patch then this would be a change in behaviour, which seems
wrong to me.

thanks
-- PMM