Re: [Qemu-block] [PATCH for-4.1] block: Assert that drv->bdrv_child_perm is set in bdrv_child_perm()

[Max Reitz]

On 04.04.19 13:29, Alberto Garcia wrote:
> There is no need to check for this because all block drivers that have
> children implement bdrv_child_perm and all callers already ensure that
> bs->drv is set.
> 
> Furthermore, if this check would fail then the callers would end up
> with uninitialized values for nperm and nshared.
> 
> This patch replaces the check with an assertion.
> 
> Signed-off-by: Alberto Garcia <address@hidden>
> ---
>  block.c | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)

Thanks, applied to my block branch:

https://git.xanclic.moe/XanClic/qemu/commits/branch/block

Max

signature.asc
Description: OpenPGP digital signature