Re: [Qemu-block] [Qemu-devel] [PATCH for-QEMU-4.1 v5 06/29] hw/arm: Express dependencies of integratorcp with Kconfig

[Thomas Huth]

On 25/04/2019 16.22, Philippe Mathieu-Daudé wrote:
> On 4/25/19 4:14 PM, Philippe Mathieu-Daudé wrote:
>> Hi Thomas,
>>
>> On 4/18/19 8:00 PM, Thomas Huth wrote:
>>> This patch is slightly based on earlier work by Ákos Kovács (i.e.
>>> his "hw/arm/Kconfig: Add ARM Kconfig" patch).
>>>
>>> Signed-off-by: Thomas Huth <address@hidden>
>>> ---
>>>  default-configs/arm-softmmu.mak | 8 +-------
>>>  hw/arm/Kconfig                  | 8 ++++++++
>>>  hw/display/Kconfig              | 1 +
>>>  3 files changed, 10 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/default-configs/arm-softmmu.mak 
>>> b/default-configs/arm-softmmu.mak
>>> index 50a4be3cad..6195b75f48 100644
>>> --- a/default-configs/arm-softmmu.mak
>>> +++ b/default-configs/arm-softmmu.mak
>>> @@ -9,6 +9,7 @@ CONFIG_PCI_TESTDEV=y
>>>  
>>>  CONFIG_EXYNOS4=y
>>>  CONFIG_HIGHBANK=y
>>> +CONFIG_INTEGRATOR=y
>>>  
>>>  CONFIG_VGA=y
>>>  CONFIG_NAND=y
>>> @@ -33,7 +34,6 @@ CONFIG_ADS7846=y
>>>  CONFIG_MAX111X=y
>>>  CONFIG_SSI_SD=y
>>>  CONFIG_SSI_M25P80=y
>>> -CONFIG_SMC91C111=y
>>>  CONFIG_ALLWINNER_EMAC=y
>>>  CONFIG_IMX_FEC=y
>>>  CONFIG_FTGMAC100=y
>>> @@ -50,10 +50,7 @@ CONFIG_ARM11MPCORE=y
>>>  CONFIG_NETDUINO2=y
>>>  
>>>  CONFIG_PL041=y
>>> -CONFIG_PL050=y
>>
>> You remove this device but it is used by the realview/versatile/vexpress
>> (you add it to these machines later in patch 11).
> 
> My worry is the unlikely event of someone checking out a new branch
> after this patch and before patch 11, and disable CONFIG_INTEGRATOR,
> then these 3 machines would fail to build.

Yeah, the basic idea in this series is that you can not easily do
partial qemu-system-arm builds anyway as long as not all boards are
converted. So I think this should be ok.

> Since it is very unlikely:
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

Thanks!

 Thomas