[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] scsi-generic: prevent guest from exceeding SG_I
|
From: |
Stefan Hajnoczi |
|
Subject: |
Re: [Qemu-block] [PATCH] scsi-generic: prevent guest from exceeding SG_IO limits |
|
Date: |
Wed, 17 Apr 2019 13:30:18 +0100 |
On Wed, Apr 17, 2019 at 12:54 PM Paolo Bonzini <address@hidden> wrote:
> Linux places a limit of UIO_MAXIOV pages on SG_IO ioctls (and if the limit
> is exceeded, a confusing ENOMEM error is returned[1]). Prevent the guest
> from exceeding these limits, by capping the maximum transfer length to
> that value in the block limits VPD page.
>
> [1] Oh well, at least it was easier to follow the kernel source knowing
> it had to end as ENOMEM...
>
> Cc: address@hidden
> Cc: address@hidden
> Cc: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> hw/scsi/scsi-generic.c | 17 +++++++++++++----
> 1 file changed, 13 insertions(+), 4 deletions(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>