[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH 4/4] qcow2: Fix full preallocation with external
From: |
Eric Blake |
Subject: |
Re: [Qemu-block] [PATCH 4/4] qcow2: Fix full preallocation with external data file |
Date: |
Mon, 15 Apr 2019 11:34:37 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 |
On 4/15/19 10:54 AM, Kevin Wolf wrote:
> preallocate_co() already gave the data file the full size without
> forwarding the requested preallocation mode to the protocol. When
> bdrv_co_truncate() was called later with the preallocation mode, the
> file didn't actually grow any more, so the data file stayed unallocated
> even if full preallocation was requested.
>
> Pass the right preallocation mode to preallocate_co() and remove the
> second bdrv_co_truncate() to fix this. As a side effect, the ugly
> one-byte write in preallocate_co() is replaced with a truncate call,
> now leaving the last block unallocated on the protocol level as it
> should be.
>
> Cc: address@hidden
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> block/qcow2.c | 41 +++++++++++++++++++++++------------------
> 1 file changed, 23 insertions(+), 18 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
Worth iotest coverage?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-block] [PATCH 0/4] qcow2: Preallocation fixes, Kevin Wolf, 2019/04/15
- [Qemu-block] [PATCH 1/4] qcow2: Avoid COW during metadata preallocation, Kevin Wolf, 2019/04/15
- [Qemu-block] [PATCH for-4.0? 2/4] qcow2: Fix preallocation bdrv_pwrite to wrong file, Kevin Wolf, 2019/04/15
- [Qemu-block] [PATCH 4/4] qcow2: Fix full preallocation with external data file, Kevin Wolf, 2019/04/15
- Re: [Qemu-block] [PATCH 4/4] qcow2: Fix full preallocation with external data file,
Eric Blake <=
- [Qemu-block] [PATCH 3/4] qcow2: Add errp to preallocate_co(), Kevin Wolf, 2019/04/15
- Re: [Qemu-block] [PATCH 0/4] qcow2: Preallocation fixes, Kevin Wolf, 2019/04/29