[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH] iotests: Let 245 pass on tmpfs
|
From: |
Alberto Garcia |
|
Subject: |
Re: [Qemu-block] [PATCH] iotests: Let 245 pass on tmpfs |
|
Date: |
Thu, 11 Apr 2019 14:44:30 +0200 |
|
User-agent: |
Notmuch/0.18.2 (http://notmuchmail.org) Emacs/24.4.1 (i586-pc-linux-gnu) |
On Wed 10 Apr 2019 06:29:18 PM CEST, Max Reitz wrote:
> # Reopen an image several times changing some of its options
> def test_reopen(self):
> + # Check whether the filesystem supports O_DIRECT
> + if 'O_DIRECT' in qemu_io('-f', 'raw', '-t', 'none', '-c', 'quit',
> hd_path[0]):
> + supports_direct = False
> + else:
> + supports_direct = True
I don't see any other test needing this at the moment (at least none
written in Python), but I wonder if this is something worth having in
iotests.py.
The patch looks fine anyway.
Reviewed-by: Alberto Garcia <address@hidden>
Berto