Re: [Qemu-block] [Qemu-devel] [PATCH 01/10] block/pflash_cfi02: Add test for supported commands

[Stephen Checkoway]

On Apr 9, 2019, at 02:13, Thomas Huth <address@hidden> wrote:

> We'd like to get rid of global_qtest in the long run (since it is
> causing trouble for tests that run multiple instances of QEMU in
> parallel, e.g. migration tests)... so if it is feasible, please don't
> use it in new code anymore. Try to use a local variable in the function
> that call qtest_initf() and pass the test state around via a parameter
> to the functions that need it.

One of the patches introduces a FlashConfig structure which gets passed around 
to all the functions. I could stuff the local qtest in there. The earlier 
patches would still use global_qtest. Would that be acceptable or would you 
prefer that global_qtest not appear in any of the patches?

Or rather than putting it in the FlashConfig struct, I could just pass a 
separate parameter around. Whatever you prefer.

-- 
Stephen Checkoway