|
From: | Markus Armbruster |
Subject: | Re: [Qemu-block] [Qemu-devel] [PATCH 01/10] block/pflash_cfi02: Add test for supported commands |
Date: | Tue, 09 Apr 2019 09:45:45 +0200 |
User-agent: | Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
Thomas Huth <address@hidden> writes: > We'd like to get rid of global_qtest in the long run (since it is > causing trouble for tests that run multiple instances of QEMU in > parallel, e.g. migration tests)... so if it is feasible, please don't > use it in new code anymore. Try to use a local variable in the function > that call qtest_initf() and pass the test state around via a parameter > to the functions that need it. Twenty tests still use @global_qtest Either we're serious about getting rid of @global_qtest. Then we should just do it. Or we're not. Then we shouldn't ask contributors to do extra work.
[Prev in Thread] | Current Thread | [Next in Thread] |