Re: [Qemu-block] [PATCH 3/7] nbd/server: Don't fail NBD_OPT_INFO for byte-aligned sources

[Vladimir Sementsov-Ogievskiy]

03.04.2019 6:05, Eric Blake wrote:
> In commit 0c1d50bd, I added a couple of TODO comments about whether we
> consult bl.request_alignment when responding to NBD_OPT_INFO. At the
> time, qemu as server was hard-coding an advertised alignment of 512 to
> clients that promised to obey constraints, and there was no function
> for getting at a device's preferred alignment. But in hindsight,
> advertising 512 when the block device prefers 1 caused other
> compliance problems, and commit b0245d64 changed one of the two TODO
> comments to advertise a more accurate alignment. Time to fix the other
> TODO.  Doesn't really impact qemu as client (our normal client doesn't
> use NBD_OPT_INFO, and qemu-nbd --list promises to obey block sizes),
> but it might prove useful to other clients.
> 
> Fixes: b0245d64
> Signed-off-by: Eric Blake <address@hidden>


Reviewed-by: Vladimir Sementsov-Ogievskiy <address@hidden>


-- 
Best regards,
Vladimir