[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-block] [PATCH for-4.0] hmp: Fix drive_add ... format=help cras
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-block] [PATCH for-4.0] hmp: Fix drive_add ... format=help crash |
|
Date: |
Fri, 5 Apr 2019 14:51:40 +0200 |
|
User-agent: |
Mutt/1.11.3 (2019-02-01) |
Am 05.04.2019 um 13:45 hat Markus Armbruster geschrieben:
> drive_new() returns null without setting an error when it provided
> help. add_init_drive() assumes null means failure, and crashes trying
> to report a null error.
>
> Fixes: c4f26c9f37ce511e5fe629c21c180dc6eb7c5a25
> Cc: address@hidden
> Signed-off-by: Markus Armbruster <address@hidden>
We should probably have a test case for this.
Kevin